-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mysql_replication: remove mode values and ret values containing master / slave #252
mysql_replication: remove mode values and ret values containing master / slave #252
Conversation
Codecov Report
@@ Coverage Diff @@
## main #252 +/- ##
==========================================
+ Coverage 77.99% 78.44% +0.44%
==========================================
Files 24 24
Lines 2159 2134 -25
Branches 508 498 -10
==========================================
- Hits 1684 1674 -10
+ Misses 309 301 -8
+ Partials 166 159 -7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Should we test for expected failures when using the old terminology?
Good question |
@Jorge-Rodriguez the tests have been added (the more tests the alwaysbetter), thanks:) |
@Jorge-Rodriguez thanks for reviewing! |
Now it does not work with mariadb versions <10.5, for example, 10.4.
If I use
|
@nerijus , working on this, thanks! |
SUMMARY
Relates to
#145
#147
#150
#97
Will be release as a breaking change with 3.0.0