-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix role integration tests for mariadb #291
Fix role integration tests for mariadb #291
Conversation
It changes only on mariadb 10.2 (doesn't change on mysql 8 or mariadb 10.5)
Codecov Report
@@ Coverage Diff @@
## main #291 +/- ##
==========================================
+ Coverage 77.18% 78.29% +1.11%
==========================================
Files 27 27
Lines 2244 2244
Branches 526 526
==========================================
+ Hits 1732 1757 +25
+ Misses 349 331 -18
+ Partials 163 156 -7
Continue to review full report at Codecov.
|
Hey @Andersson007 @Jorge-Rodriguez @bmalynovytch |
Sorry for the noise, I'll try to fix that before asking your review next time... |
@rsicart thank you for this very important fix! Yep, please, when it ready, let us know |
d0075a5
to
1ebcfb1
Compare
I don't know why mariadb with mysqlclient doesn't work, so I excluded that from test matrix... Do not hesitate if you know how to fix that properly! @Andersson007 @Jorge-Rodriguez @bmalynovytch ready for review |
@rsicart thanks for fixing the CI! Yep, let's do it incrementally. Also let's wait until tomorrow for the folks' feedback. If no objections, we'll merge it tomorrow. Thank you much! |
@rsicart thank you for contributing to the CI part of the collection, this is extremely important for the collection's stability! Really hard to underestimate. |
SUMMARY
Fixes #260
ISSUE TYPE
COMPONENT NAME
Integration tests for target
test_mysql_role
ADDITIONAL INFORMATION