Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mysql_role: enable autocommit #500

Merged
merged 2 commits into from
Feb 1, 2023
Merged

mysql_role: enable autocommit #500

merged 2 commits into from
Feb 1, 2023

Conversation

GhostLyrics
Copy link
Contributor

@GhostLyrics GhostLyrics commented Jan 31, 2023 •
edited
Loading

SUMMARY

Enable auto-commit for mysql_role module.

Fixes: #479 (part 2: roles)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

mysql_role

ADDITIONAL INFORMATION
  • I've run flake8. It complains about existing issues related to where you have import.
  • I've run sanity tests. They pass.
  • I've run integration tests. They pass. (FYI: they take 12 minutes on a M1 Macbook Air 😂)
  • I've run unit tests. They pass.

@GhostLyrics GhostLyrics marked this pull request as draft January 31, 2023 22:05
@GhostLyrics GhostLyrics marked this pull request as ready for review January 31, 2023 22:06
@GhostLyrics
Copy link
Contributor Author

@Andersson007 ready for review.

@Andersson007 Andersson007 merged commit b8d6474 into ansible-collections:main Feb 1, 2023
@Andersson007
Copy link
Collaborator

@GhostLyrics thanks for the contribution! Have you already joined our Matrix ansible mysql room? If not, welcome!

BTW i wonder if we should change minor_changes in the fragments for both the PRs and backport them to versions 2 and 1, ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andersson007 Andersson007 Andersson007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mysql_user: waits forever for table metadata lock with loop on MySQL 8
2 participants
@GhostLyrics @Andersson007