-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix connection arguments for MySQLdb <2.0 !=1.0 #553
fix connection arguments for MySQLdb <2.0 !=1.0 #553
Conversation
Codecov Report
@@ Coverage Diff @@
## main #553 +/- ##
==========================================
- Coverage 76.67% 74.35% -2.32%
==========================================
Files 28 18 -10
Lines 2379 2254 -125
Branches 563 560 -3
==========================================
- Hits 1824 1676 -148
- Misses 395 407 +12
- Partials 160 171 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
The CI errors appear to be unrelated to the change:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@betanummeric feel free to merge it as is or fix the unrelated line and merge it after, as you prefer
oh, it seems to be not as streightforward as we thought. maybe as there are still not a lot of unrelated-to-this-fix change maybe revert last to commits and merge it as it was originally? (just a suggestion, if you like we could merge all stuff here) |
It appears to be just syntax errors, but in many places, hence tedious to fix. Let's fix that in another PR, I will revert the attempt to fix it here. |
0f1d1d8
to
218f854
Compare
SGTM, thanks |
fixes #546 and #551