Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql_info - add table count to the databases returned values #691

Conversation

laurent-indermuehle
Copy link
Collaborator

@laurent-indermuehle laurent-indermuehle commented Nov 18, 2024

SUMMARY

This PR adds the count of tables for each database to the returned values of the mysql_info plugin.
As for size, it is possible to exclude this new field using the db_table_count filter.

In case the schema has no tables, the count is returned as 0.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

mysql_info

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.10%. Comparing base (28bf709) to head (d42c0ce).
Report is 7 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #691       +/-   ##
===========================================
+ Coverage   25.74%   77.10%   +51.35%     
===========================================
  Files          32       20       -12     
  Lines        2808     2660      -148     
  Branches      704      676       -28     
===========================================
+ Hits          723     2051     +1328     
+ Misses       2044      413     -1631     
- Partials       41      196      +155     
Flag Coverage Δ
integration 76.46% <100.00%> (?)
sanity ?
units ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@laurent-indermuehle laurent-indermuehle marked this pull request as ready for review November 18, 2024 12:42
@laurent-indermuehle laurent-indermuehle self-assigned this Nov 18, 2024
@laurent-indermuehle laurent-indermuehle merged commit 9057637 into ansible-collections:main Nov 19, 2024
57 checks passed
@laurent-indermuehle laurent-indermuehle deleted the lie_add_table_count_to_mysql_info_databases branch November 19, 2024 07:51
@Andersson007
Copy link
Collaborator

@laurent-indermuehle thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants