Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgresql_info: fix crash when extension version is 0. #138

Merged
merged 3 commits into from
Sep 10, 2021
Merged

postgresql_info: fix crash when extension version is 0. #138

merged 3 commits into from
Sep 10, 2021

Conversation

Andersson007
Copy link
Collaborator

@Andersson007 Andersson007 commented Sep 6, 2021 •
edited
Loading

SUMMARY

Fixes #137
Fixes #136

postgresql_info:

  • fix crash when extension version is 0.
  • add raw ret value for extensions

postgresql_ext (i put it in this PR because it needs for integration tests):

  • fix extension of version 0 handling
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/modules/postgresql_ext.py
plugins/modules/postgresql_info.py

@Andersson007
Copy link
Collaborator Author

cc @phemmer @tcraxs @kostiantyn-nemchenko @hunleyd

@Andersson007 Andersson007 mentioned this pull request Sep 6, 2021
Closed
tcraxs
tcraxs approved these changes Sep 6, 2021
View reviewed changes
Copy link
Contributor

@tcraxs tcraxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change/hint in the changelog, other parts LGTM. Thanks @Andersson007

changelogs/fragments/138-postgresql_info_fix_ver_handling.yml Outdated Show resolved Hide resolved
tcraxs
tcraxs approved these changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@tcraxs tcraxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Andersson007
Copy link
Collaborator Author

fyi: there's unrelated CI bug ansible/ansible#75647, please ignore

@Andersson007 Andersson007 merged commit bede720 into ansible-collections:main Sep 10, 2021
@Andersson007
Copy link
Collaborator Author

Andersson007 commented Sep 10, 2021 •
edited
Loading

@phemmer thanks for reporting the issue!
@tcraxs @phemmer @hunleyd (i saw your thumbs up) thanks for reviewing!

@Andersson007 Andersson007 mentioned this pull request Sep 10, 2021
Closed
@Andersson007
Copy link
Collaborator Author

community.postgresql 1.5.0 has been released and is available to install via the ansible-galaxy command.
It also contains these changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcraxs tcraxs tcraxs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

extension version without decimal causes postgresql_info exception postgresql_ext can't handle '0' version
2 participants
@Andersson007 @tcraxs