Deprecate rename and rename_to choices/options

[Andersson007]

SUMMARY

Fixes #820

[andreasscherbaum]

I'd love to see an explanation as to why this is deprecated, but I don't know what is the right place for it.

Basically summarizing the discussion, pointing out that using "rename" is not playing well with state-based systems like Ansible.

[Andersson007]

I'd love to see an explanation as to why this is deprecated, but I don't know what is the right place for it.

Basically summarizing the discussion, pointing out that using "rename" is not playing well with state-based systems like Ansible.

@andreasscherbaum SGTM, i would avoid putting to much in the option's docs tough, how about:

Option 1: we add a link to the GH discussion which would give the full context, something like:

DEPRECATED (see the L(discussion,https://github.com/ansible-collections/community.postgresql/issues/820)). C(rename) is used to rename the database C(name) to C(target).
To rename a database, use the M(community.postgresql.postgresql_query) module.

Option 2: Add a more verbose note to the notes: section of the DOCUMENTATION block and refer from the option's doc to the note (though I personally like the link to the discussion option).

Thoughts, folks?

[andreasscherbaum]

Option 1 is already fine, I think. It's about giving users an idea as to why this is deprecated. Otherwise the discussion might start again.

[Andersson007]

Option 1 is already fine, I think. It's about giving users an idea as to why this is deprecated. Otherwise the discussion might start again.

Done, PTAL, thanks

[andreasscherbaum]

Looks good.

[Andersson007]

@andreasscherbaum @hunleyd thanks for reviewing and approving the changes!