Skip to content

Commit

Permalink
Add "interface ppp-client" to API data
Browse files Browse the repository at this point in the history
The default values match those of RouterOS 7.11 on a Mikrotik
RB924i-2nD-BT5&BG77 ("Knot").

Upstream documentation: https://help.mikrotik.com/docs/display/ROS/PPP

Signed-off-by: Michael Hanselmann <public@hansmi.ch>
  • Loading branch information
hansmi committed Aug 16, 2023
1 parent 3b127b1 commit 91ff318
Show file tree
Hide file tree
Showing 4 changed files with 34 additions and 0 deletions.
2 changes: 2 additions & 0 deletions changelogs/fragments/199-add-interface-pppclient.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
minor_changes:
- api_info, api_modify - add support for the ``interface ppp-client`` path (https://github.com/ansible-collections/community.routeros/pull/199).
30 changes: 30 additions & 0 deletions plugins/module_utils/_api_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,36 @@ def join_path(path):
'use-peer-dns': KeyInfo(),
},
),
('interface', 'ppp-client'): APIData(
fully_understood=True,
primary_keys=('name', ),
fields={
'add-default-route': KeyInfo(default=True),
'allow': KeyInfo(default='pap,chap,mschap1,mschap2'),
'comment': KeyInfo(can_disable=True, remove_value=''),
'data-channel': KeyInfo(default=0),
'default-route-distance': KeyInfo(default=1),
'dial-command': KeyInfo(),
'dial-on-demand': KeyInfo(default=True),
'disabled': KeyInfo(default=True),
'info-channel': KeyInfo(default=0),
'keepalive-timeout': KeyInfo(default=30),
'max-mru': KeyInfo(default=1500),
'max-mtu': KeyInfo(default=1500),
'modem-init': KeyInfo(default=''),
'mrru': KeyInfo(default='disabled'),
'name': KeyInfo(),
'null-modem': KeyInfo(default=False),
'password': KeyInfo(default=''),
'phone': KeyInfo(default=''),
'pin': KeyInfo(default=''),
'port': KeyInfo(),
'profile': KeyInfo(default='default'),
'running': KeyInfo(default=False),
'use-peer-dns': KeyInfo(default=True),
'user': KeyInfo(default=''),
},
),
('interface', 'pppoe-client'): APIData(
fully_understood=True,
primary_keys=('name', ),
Expand Down
1 change: 1 addition & 0 deletions plugins/modules/api_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@
- interface list
- interface list member
- interface ovpn-server server
- interface ppp-client
- interface pppoe-client
- interface pptp-server server
- interface sstp-server server
Expand Down
1 change: 1 addition & 0 deletions plugins/modules/api_modify.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@
- interface list
- interface list member
- interface ovpn-server server
- interface ppp-client
- interface pppoe-client
- interface pptp-server server
- interface sstp-server server
Expand Down

0 comments on commit 91ff318

Please sign in to comment.