Skip to content

Commit

Permalink
Fixes #179: Add missing /tool/e-mail parameter "tls" (#180)
Browse files Browse the repository at this point in the history
* Fixes #179: Add missing /tool/e-mail parameter "tls"

In the
[documentation](https://help.mikrotik.com/docs/display/ROS/E-mail#Email-Properties) the parameter "tls" is mentioned but it cannot be used. The old "start-tls" parameter is not mentioned there (only on the [old documentation](https://wiki.mikrotik.com/wiki/Manual:Tools/email#Properties)).
Trying to use the paramter "tls" lead to the erro message `FAILED! => {"changed": false, "msg": "Unknown key \"tls\"."}`.

* Add changelog fragment

* Update changelogs/fragments/180-fix-tls-in-tool-email.yml

As suggested by felixfontein

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Johannes Münch <git@washiza.eu>
Co-authored-by: Felix Fontein <felix@fontein.de>
  • Loading branch information
3 people authored Jun 19, 2023
1 parent d098c20 commit af28e64
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
2 changes: 2 additions & 0 deletions changelogs/fragments/180-fix-tls-in-tool-email.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bugfixes:
- api_modify, api_info - add missing parameter ``tls`` for the ``tool e-mail`` path (https://github.com/ansible-collections/community.routeros/issues/179, https://github.com/ansible-collections/community.routeros/pull/180).
1 change: 1 addition & 0 deletions plugins/module_utils/_api_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -2451,6 +2451,7 @@ def join_path(path):
'password': KeyInfo(default=''),
'port': KeyInfo(default=25),
'start-tls': KeyInfo(default=False),
'tls': KeyInfo(default=False),
'user': KeyInfo(default=''),
},
),
Expand Down

0 comments on commit af28e64

Please sign in to comment.