Fix default of ingress-filtering for ROS < 7.

ansible-collections · Aug 11, 2024 · f3a33d3 · f3a33d3
1 parent 78466d0
commit f3a33d3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/changelogs/fragments/306-ingress-filtering-ros6.yml b/changelogs/fragments/306-ingress-filtering-ros6.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - "api_modify, api_info - change the default of ``ingress-filtering`` in paths ``interface bridge`` and ``interface bridge port`` back to ``false`` for RouterOS before version 7 (https://github.com/ansible-collections/community.routeros/pull/305)."
diff --git a/plugins/module_utils/_api_data.py b/plugins/module_utils/_api_data.py
@@ -259,6 +259,10 @@ def join_path(path):
  unversioned=VersionedAPIData(
  fully_understood=True,
  primary_keys=('name', ),
+ versioned_fields=[
+ ([('7.0', '<')], 'ingress-filtering', KeyInfo(default=False)),
+ ([('7.0', '>=')], 'ingress-filtering', KeyInfo(default=True)),
+ ],
  fields={
  'admin-mac': KeyInfo(default=''),
  'ageing-time': KeyInfo(default='5m'),
@@ -273,7 +277,6 @@ def join_path(path):
  'frame-types': KeyInfo(default='admit-all'),
  'forward-delay': KeyInfo(default='15s'),
  'igmp-snooping': KeyInfo(default=False),
- 'ingress-filtering': KeyInfo(default=True),
  'max-message-age': KeyInfo(default='20s'),
  'mtu': KeyInfo(default='auto'),
  'name': KeyInfo(),
@@ -1310,6 +1313,10 @@ def join_path(path):
  unversioned=VersionedAPIData(
  fully_understood=True,
  primary_keys=('interface', ),
+ versioned_fields=[
+ ([('7.0', '<')], 'ingress-filtering', KeyInfo(default=False)),
+ ([('7.0', '>=')], 'ingress-filtering', KeyInfo(default=True)),
+ ],
  fields={
  'auto-isolate': KeyInfo(default=False),
  'bpdu-guard': KeyInfo(default=False),
@@ -1322,7 +1329,6 @@ def join_path(path):
  'frame-types': KeyInfo(default='admit-all'),
  'horizon': KeyInfo(default='none'),
  'hw': KeyInfo(default=True),
- 'ingress-filtering': KeyInfo(default=True),
  'interface': KeyInfo(),
  'internal-path-cost': KeyInfo(default=10),
  'learn': KeyInfo(default='auto'),