Added timeout setting for api. #109

TobsA13 · 2022-08-31T13:47:34Z

Added timeout setting for the API request.

At the moment the timeout of librouteros is by default 10 seconds. For some tasks this is to short.
librouteros already provides an option to overwrite the timeout. This commit add the parameter to this module.

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

Only affects the api part of the module. Added timeout parameter.

ADDITIONAL INFORMATION

Sorry don't know how the create the verbatim output.

github-actions · 2022-08-31T13:48:57Z

Docs Build 📝

Thank you for contribution!✨

The docsite for this PR is available for download as an artifact from this run:
https://github.com/ansible-collections/community.routeros/actions/runs/2989641143

File changes:

M collections/community/routeros/api_facts_module.html

M collections/community/routeros/api_find_and_modify_module.html

M collections/community/routeros/api_info_module.html

M collections/community/routeros/api_modify_module.html

M collections/community/routeros/api_module.html

Click to see the diff comparison.

NOTE: only file modifications are shown here. New and deleted files are excluded.
See the file list and check the published docs to see those files.

diff --git a/home/runner/work/community.routeros/community.routeros/docsbuild/base/collections/community/routeros/api_facts_module.html b/home/runner/work/community.routeros/community.routeros/docsbuild/head/collections/community/routeros/api_facts_module.html
index a496d4f..3e40fa0 100644
--- a/home/runner/work/community.routeros/community.routeros/docsbuild/base/collections/community/routeros/api_facts_module.html
+++ b/home/runner/work/community.routeros/community.routeros/docsbuild/head/collections/community/routeros/api_facts_module.html
@@ -220,6 +220,15 @@ see <a class="reference internal" href="#ansible-collections-community-routeros-
 </div></td>
 </tr>
 <tr class="row-even"><td><div class="ansible-option-cell">
+<div class="ansibleOptionAnchor" id="parameter-timeout"></div><p class="ansible-option-title" id="ansible-collections-community-routeros-api-facts-module-parameter-timeout"><strong>timeout</strong></p>
+<a class="ansibleOptionLink" href="#parameter-timeout" title="Permalink to this option"></a><p class="ansible-option-type-line"><span class="ansible-option-type">integer</span></p>
+<p><span class="ansible-option-versionadded">added in 2.3.0 of community.routeros</span></p>
+</div></td>
+<td><div class="ansible-option-cell"><p>Timeout for the request.</p>
+<p class="ansible-option-line"><span class="ansible-option-default-bold">Default:</span> <span class="ansible-option-default">10</span></p>
+</div></td>
+</tr>
+<tr class="row-odd"><td><div class="ansible-option-cell">
 <div class="ansibleOptionAnchor" id="parameter-tls"></div>
 <div class="ansibleOptionAnchor" id="parameter-ssl"></div><p class="ansible-option-title" id="ansible-collections-community-routeros-api-facts-module-parameter-tls"><span id="ansible-collections-community-routeros-api-facts-module-parameter-ssl"></span><strong>tls</strong></p>
 <a class="ansibleOptionLink" href="#parameter-tls" title="Permalink to this option"></a><p class="ansible-option-type-line"><span class="ansible-option-aliases">aliases: ssl</span></p>
@@ -233,14 +242,14 @@ see <a class="reference internal" href="#ansible-collections-community-routeros-
 </ul>
 </div></td>
 </tr>
-<tr class="row-odd"><td><div class="ansible-option-cell">
+<tr class="row-even"><td><div class="ansible-option-cell">
 <div class="ansibleOptionAnchor" id="parameter-username"></div><p class="ansible-option-title" id="ansible-collections-community-routeros-api-facts-module-parameter-username"><strong>username</strong></p>
 <a class="ansibleOptionLink" href="#parameter-username" title="Permalink to this option"></a><p class="ansible-option-type-line"><span class="ansible-option-type">string</span> / <span class="ansible-option-required">required</span></p>
 </div></td>
 <td><div class="ansible-option-cell"><p>RouterOS login user.</p>
 </div></td>
 </tr>
-<tr class="row-even"><td><div class="ansible-option-cell">
+<tr class="row-odd"><td><div class="ansible-option-cell">
 <div class="ansibleOptionAnchor" id="parameter-validate_cert_hostname"></div><p class="ansible-option-title" id="ansible-collections-community-routeros-api-facts-module-parameter-validate-cert-hostname"><strong>validate_cert_hostname</strong></p>
 <a class="ansibleOptionLink" href="#parameter-validate_cert_hostname" title="Permalink to this option"></a><p class="ansible-option-type-line"><span class="ansible-option-type">boolean</span></p>
 <p><span class="ansible-option-versionadded">added in 1.2.0 of community.routeros</span></p>
@@ -254,7 +263,7 @@ see <a class="reference internal" href="#ansible-collections-community-routeros-
 </ul>
 </div></td>
 </tr>
-<tr class="row-odd"><td><div class="ansible-option-cell">
+<tr class="row-even"><td><div class="ansible-option-cell">
 <div class="ansibleOptionAnchor" id="parameter-validate_certs"></div><p class="ansible-option-title" id="ansible-collections-community-routeros-api-facts-module-parameter-validate-certs"><strong>validate_certs</strong></p>
 <a class="ansibleOptionLink" href="#parameter-validate_certs" title="Permalink to this option"></a><p class="ansible-option-type-line"><span class="ansible-option-type">boolean</span></p>
 <p><span class="ansible-option-versionadded">added in 1.2.0 of community.routeros</span></p>
diff --git a/home/runner/work/community.routeros/community.routeros/docsbuild/base/collections/community/routeros/api_find_and_modify_module.html b/home/runner/work/community.routeros/community.routeros/docsbuild/head/collections/community/routeros/api_find_and_modify_module.html
index 44ccf70..5be4c88 100644
--- a/home/runner/work/community.routeros/community.routeros/docsbuild/base/collections/community/routeros/api_find_and_modify_module.html
+++ b/home/runner/work/community.routeros/community.routeros/docsbuild/head/collections/community/routeros/api_find_and_modify_module.html
@@ -261,6 +261,15 @@ see <a class="reference internal" href="#ansible-collections-community-routeros-
 </div></td>
 </tr>
 <tr class="row-even"><td><div class="ansible-option-cell">
+<div class="ansibleOptionAnchor" id="parameter-timeout"></div><p class="ansible-option-title" id="ansible-collections-community-routeros-api-find-and-modify-module-parameter-timeout"><strong>timeout</strong></p>
+<a class="ansibleOptionLink" href="#parameter-timeout" title="Permalink to this option"></a><p class="ansible-option-type-line"><span class="ansible-option-type">integer</span></p>
+<p><span class="ansible-option-versionadded">added in 2.3.0 of community.routeros</span></p>
+</div></td>
+<td><div class="ansible-option-cell"><p>Timeout for the request.</p>
+<p class="ansible-option-line"><span class="ansible-option-default-bold">Default:</span> <span class="ansible-option-default">10</span></p>
+</div></td>
+</tr>
+<tr class="row-odd"><td><div class="ansible-option-cell">
 <div class="ansibleOptionAnchor" id="parameter-tls"></div>
 <div class="ansibleOptionAnchor" id="parameter-ssl"></div><p class="ansible-option-title" id="ansible-collections-community-routeros-api-find-and-modify-module-parameter-tls"><span id="ansible-collections-community-routeros-api-find-and-modify-module-parameter-ssl"></span><strong>tls</strong></p>
 <a class="ansibleOptionLink" href="#parameter-tls" title="Permalink to this option"></a><p class="ansible-option-type-line"><span class="ansible-option-aliases">aliases: ssl</span></p>
@@ -274,14 +283,14 @@ see <a class="reference internal" href="#ansible-collections-community-routeros-
 </ul>
 </div></td>
 </tr>
-<tr class="row-odd"><td><div class="ansible-option-cell">
+<tr class="row-even"><td><div class="ansible-option-cell">
 <div class="ansibleOptionAnchor" id="parameter-username"></div><p class="ansible-option-title" id="ansible-collections-community-routeros-api-find-and-modify-module-parameter-username"><strong>username</strong></p>
 <a class="ansibleOptionLink" href="#parameter-username" title="Permalink to this option"></a><p class="ansible-option-type-line"><span class="ansible-option-type">string</span> / <span class="ansible-option-required">required</span></p>
 </div></td>
 <td><div class="ansible-option-cell"><p>RouterOS login user.</p>
 </div></td>
 </tr>
-<tr class="row-even"><td><div class="ansible-option-cell">
+<tr class="row-odd"><td><div class="ansible-option-cell">
 <div class="ansibleOptionAnchor" id="parameter-validate_cert_hostname"></div><p class="ansible-option-title" id="ansible-collections-community-routeros-api-find-and-modify-module-parameter-validate-cert-hostname"><strong>validate_cert_hostname</strong></p>
 <a class="ansibleOptionLink" href="#parameter-validate_cert_hostname" title="Permalink to this option"></a><p class="ansible-option-type-line"><span class="ansible-option-type">boolean</span></p>
 <p><span class="ansible-option-versionadded">added in 1.2.0 of community.routeros</span></p>
@@ -295,7 +304,7 @@ see <a class="reference internal" href="#ansible-collections-community-routeros-
 </ul>
 </div></td>
 </tr>
-<tr class="row-odd"><td><div class="ansible-option-cell">
+<tr class="row-even"><td><div class="ansible-option-cell">
 <div class="ansibleOptionAnchor" id="parameter-validate_certs"></div><p class="ansible-option-title" id="ansible-collections-community-routeros-api-find-and-modify-module-parameter-validate-certs"><strong>validate_certs</strong></p>
 <a class="ansibleOptionLink" href="#parameter-validate_certs" title="Permalink to this option"></a><p class="ansible-option-type-line"><span class="ansible-option-type">boolean</span></p>
 <p><span class="ansible-option-versionadded">added in 1.2.0 of community.routeros</span></p>
@@ -310,7 +319,7 @@ see <a class="reference internal" href="#ansible-collections-community-routeros-
 </ul>
 </div></td>
 </tr>
-<tr class="row-even"><td><div class="ansible-option-cell">
+<tr class="row-odd"><td><div class="ansible-option-cell">
 <div class="ansibleOptionAnchor" id="parameter-values"></div><p class="ansible-option-title" id="ansible-collections-community-routeros-api-find-and-modify-module-parameter-values"><strong>values</strong></p>
 <a class="ansibleOptionLink" href="#parameter-values" title="Permalink to this option"></a><p class="ansible-option-type-line"><span class="ansible-option-type">dictionary</span> / <span class="ansible-option-required">required</span></p>
 </div></td>
diff --git a/home/runner/work/community.routeros/community.routeros/docsbuild/base/collections/community/routeros/api_info_module.html b/home/runner/work/community.routeros/community.routeros/docsbuild/head/collections/community/routeros/api_info_module.html
index b09df7b..79a4a53 100644
--- a/home/runner/work/community.routeros/community.routeros/docsbuild/base/collections/community/routeros/api_info_module.html
+++ b/home/runner/work/community.routeros/community.routeros/docsbuild/head/collections/community/routeros/api_info_module.html
@@ -355,6 +355,15 @@ see <a class="reference internal" href="#ansible-collections-community-routeros-
 </div></td>
 </tr>
 <tr class="row-odd"><td><div class="ansible-option-cell">
+<div class="ansibleOptionAnchor" id="parameter-timeout"></div><p class="ansible-option-title" id="ansible-collections-community-routeros-api-info-module-parameter-timeout"><strong>timeout</strong></p>
+<a class="ansibleOptionLink" href="#parameter-timeout" title="Permalink to this option"></a><p class="ansible-option-type-line"><span class="ansible-option-type">integer</span></p>
+<p><span class="ansible-option-versionadded">added in 2.3.0 of community.routeros</span></p>
+</div></td>
+<td><div class="ansible-option-cell"><p>Timeout for the request.</p>
+<p class="ansible-option-line"><span class="ansible-option-default-bold">Default:</span> <span class="ansible-option-default">10</span></p>
+</div></td>
+</tr>
+<tr class="row-even"><td><div class="ansible-option-cell">
 <div class="ansibleOptionAnchor" id="parameter-tls"></div>
 <div class="ansibleOptionAnchor" id="parameter-ssl"></div><p class="ansible-option-title" id="ansible-collections-community-routeros-api-info-module-parameter-tls"><span id="ansible-collections-community-routeros-api-info-module-parameter-ssl"></span><strong>tls</strong></p>
 <a class="ansibleOptionLink" href="#parameter-tls" title="Permalink to this option"></a><p class="ansible-option-type-line"><span class="ansible-option-aliases">aliases: ssl</span></p>
@@ -368,7 +377,7 @@ see <a class="reference internal" href="#ansible-collections-community-routeros-
 </ul>
 </div></td>
 </tr>
-<tr class="row-even"><td><div class="ansible-option-cell">
+<tr class="row-odd"><td><div class="ansible-option-cell">
 <div class="ansibleOptionAnchor" id="parameter-unfiltered"></div><p class="ansible-option-title" id="ansible-collections-community-routeros-api-info-module-parameter-unfiltered"><strong>unfiltered</strong></p>
 <a class="ansibleOptionLink" href="#parameter-unfiltered" title="Permalink to this option"></a><p class="ansible-option-type-line"><span class="ansible-option-type">boolean</span></p>
 </div></td>
@@ -381,14 +390,14 @@ see <a class="reference internal" href="#ansible-collections-community-routeros-
 </ul>
 </div></td>
 </tr>
-<tr class="row-odd"><td><div class="ansible-option-cell">
+<tr class="row-even"><td><div class="ansible-option-cell">
 <div class="ansibleOptionAnchor" id="parameter-username"></div><p class="ansible-option-title" id="ansible-collections-community-routeros-api-info-module-parameter-username"><strong>username</strong></p>
 <a class="ansibleOptionLink" href="#parameter-username" title="Permalink to this option"></a><p class="ansible-option-type-line"><span class="ansible-option-type">string</span> / <span class="ansible-option-required">required</span></p>
 </div></td>
 <td><div class="ansible-option-cell"><p>RouterOS login user.</p>
 </div></td>
 </tr>
-<tr class="row-even"><td><div class="ansible-option-cell">
+<tr class="row-odd"><td><div class="ansible-option-cell">
 <div class="ansibleOptionAnchor" id="parameter-validate_cert_hostname"></div><p class="ansible-option-title" id="ansible-collections-community-routeros-api-info-module-parameter-validate-cert-hostname"><strong>validate_cert_hostname</strong></p>
 <a class="ansibleOptionLink" href="#parameter-validate_cert_hostname" title="Permalink to this option"></a><p class="ansible-option-type-line"><span class="ansible-option-type">boolean</span></p>
 <p><span class="ansible-option-versionadded">added in 1.2.0 of community.routeros</span></p>
@@ -402,7 +411,7 @@ see <a class="reference internal" href="#ansible-collections-community-routeros-
 </ul>
 </div></td>
 </tr>
-<tr class="row-odd"><td><div class="ansible-option-cell">
+<tr class="row-even"><td><div class="ansible-option-cell">
 <div class="ansibleOptionAnchor" id="parameter-validate_certs"></div><p class="ansible-option-title" id="ansible-collections-community-routeros-api-info-module-parameter-validate-certs"><strong>validate_certs</strong></p>
 <a class="ansibleOptionLink" href="#parameter-validate_certs" title="Permalink to this option"></a><p class="ansible-option-type-line"><span class="ansible-option-type">boolean</span></p>
 <p><span class="ansible-option-versionadded">added in 1.2.0 of community.routeros</span></p>
diff --git a/home/runner/work/community.routeros/community.routeros/docsbuild/base/collections/community/routeros/api_modify_module.html b/home/runner/work/community.routeros/community.routeros/docsbuild/head/collections/community/routeros/api_modify_module.html
index 960122c..544823a 100644
--- a/home/runner/work/community.routeros/community.routeros/docsbuild/base/collections/community/routeros/api_modify_module.html
+++ b/home/runner/work/community.routeros/community.routeros/docsbuild/head/collections/community/routeros/api_modify_module.html
@@ -367,6 +367,15 @@ see <a class="reference internal" href="#ansible-collections-community-routeros-
 </div></td>
 </tr>
 <tr class="row-even"><td><div class="ansible-option-cell">
+<div class="ansibleOptionAnchor" id="parameter-timeout"></div><p class="ansible-option-title" id="ansible-collections-community-routeros-api-modify-module-parameter-timeout"><strong>timeout</strong></p>
+<a class="ansibleOptionLink" href="#parameter-timeout" title="Permalink to this option"></a><p class="ansible-option-type-line"><span class="ansible-option-type">integer</span></p>
+<p><span class="ansible-option-versionadded">added in 2.3.0 of community.routeros</span></p>
+</div></td>
+<td><div class="ansible-option-cell"><p>Timeout for the request.</p>
+<p class="ansible-option-line"><span class="ansible-option-default-bold">Default:</span> <span class="ansible-option-default">10</span></p>
+</div></td>
+</tr>
+<tr class="row-odd"><td><div class="ansible-option-cell">
 <div class="ansibleOptionAnchor" id="parameter-tls"></div>
 <div class="ansibleOptionAnchor" id="parameter-ssl"></div><p class="ansible-option-title" id="ansible-collections-community-routeros-api-modify-module-parameter-tls"><span id="ansible-collections-community-routeros-api-modify-module-parameter-ssl"></span><strong>tls</strong></p>
 <a class="ansibleOptionLink" href="#parameter-tls" title="Permalink to this option"></a><p class="ansible-option-type-line"><span class="ansible-option-aliases">aliases: ssl</span></p>
@@ -380,14 +389,14 @@ see <a class="reference internal" href="#ansible-collections-community-routeros-
 </ul>
 </div></td>
 </tr>
-<tr class="row-odd"><td><div class="ansible-option-cell">
+<tr class="row-even"><td><div class="ansible-option-cell">
 <div class="ansibleOptionAnchor" id="parameter-username"></div><p class="ansible-option-title" id="ansible-collections-community-routeros-api-modify-module-parameter-username"><strong>username</strong></p>
 <a class="ansibleOptionLink" href="#parameter-username" title="Permalink to this option"></a><p class="ansible-option-type-line"><span class="ansible-option-type">string</span> / <span class="ansible-option-required">required</span></p>
 </div></td>
 <td><div class="ansible-option-cell"><p>RouterOS login user.</p>
 </div></td>
 </tr>
-<tr class="row-even"><td><div class="ansible-option-cell">
+<tr class="row-odd"><td><div class="ansible-option-cell">
 <div class="ansibleOptionAnchor" id="parameter-validate_cert_hostname"></div><p class="ansible-option-title" id="ansible-collections-community-routeros-api-modify-module-parameter-validate-cert-hostname"><strong>validate_cert_hostname</strong></p>
 <a class="ansibleOptionLink" href="#parameter-validate_cert_hostname" title="Permalink to this option"></a><p class="ansible-option-type-line"><span class="ansible-option-type">boolean</span></p>
 <p><span class="ansible-option-versionadded">added in 1.2.0 of community.routeros</span></p>
@@ -401,7 +410,7 @@ see <a class="reference internal" href="#ansible-collections-community-routeros-
 </ul>
 </div></td>
 </tr>
-<tr class="row-odd"><td><div class="ansible-option-cell">
+<tr class="row-even"><td><div class="ansible-option-cell">
 <div class="ansibleOptionAnchor" id="parameter-validate_certs"></div><p class="ansible-option-title" id="ansible-collections-community-routeros-api-modify-module-parameter-validate-certs"><strong>validate_certs</strong></p>
 <a class="ansibleOptionLink" href="#parameter-validate_certs" title="Permalink to this option"></a><p class="ansible-option-type-line"><span class="ansible-option-type">boolean</span></p>
 <p><span class="ansible-option-versionadded">added in 1.2.0 of community.routeros</span></p>
diff --git a/home/runner/work/community.routeros/community.routeros/docsbuild/base/collections/community/routeros/api_module.html b/home/runner/work/community.routeros/community.routeros/docsbuild/head/collections/community/routeros/api_module.html
index 932b89c..09b3136 100644
--- a/home/runner/work/community.routeros/community.routeros/docsbuild/base/collections/community/routeros/api_module.html
+++ b/home/runner/work/community.routeros/community.routeros/docsbuild/head/collections/community/routeros/api_module.html
@@ -364,6 +364,15 @@ see <a class="reference internal" href="#ansible-collections-community-routeros-
 </div></td>
 </tr>
 <tr class="row-even"><td><div class="ansible-option-cell">
+<div class="ansibleOptionAnchor" id="parameter-timeout"></div><p class="ansible-option-title" id="ansible-collections-community-routeros-api-module-parameter-timeout"><strong>timeout</strong></p>
+<a class="ansibleOptionLink" href="#parameter-timeout" title="Permalink to this option"></a><p class="ansible-option-type-line"><span class="ansible-option-type">integer</span></p>
+<p><span class="ansible-option-versionadded">added in 2.3.0 of community.routeros</span></p>
+</div></td>
+<td><div class="ansible-option-cell"><p>Timeout for the request.</p>
+<p class="ansible-option-line"><span class="ansible-option-default-bold">Default:</span> <span class="ansible-option-default">10</span></p>
+</div></td>
+</tr>
+<tr class="row-odd"><td><div class="ansible-option-cell">
 <div class="ansibleOptionAnchor" id="parameter-tls"></div>
 <div class="ansibleOptionAnchor" id="parameter-ssl"></div><p class="ansible-option-title" id="ansible-collections-community-routeros-api-module-parameter-tls"><span id="ansible-collections-community-routeros-api-module-parameter-ssl"></span><strong>tls</strong></p>
 <a class="ansibleOptionLink" href="#parameter-tls" title="Permalink to this option"></a><p class="ansible-option-type-line"><span class="ansible-option-aliases">aliases: ssl</span></p>
@@ -377,7 +386,7 @@ see <a class="reference internal" href="#ansible-collections-community-routeros-
 </ul>
 </div></td>
 </tr>
-<tr class="row-odd"><td><div class="ansible-option-cell">
+<tr class="row-even"><td><div class="ansible-option-cell">
 <div class="ansibleOptionAnchor" id="parameter-update"></div><p class="ansible-option-title" id="ansible-collections-community-routeros-api-module-parameter-update"><strong>update</strong></p>
 <a class="ansibleOptionLink" href="#parameter-update" title="Permalink to this option"></a><p class="ansible-option-type-line"><span class="ansible-option-type">string</span></p>
 </div></td>
@@ -387,14 +396,14 @@ see <a class="reference internal" href="#ansible-collections-community-routeros-
 <p>Note <code class="docutils literal notranslate"><span class="pre">number</span></code> in RouterOS CLI is different from <code class="docutils literal notranslate"><span class="pre">.id</span></code>.</p>
 </div></td>
 </tr>
-<tr class="row-even"><td><div class="ansible-option-cell">
+<tr class="row-odd"><td><div class="ansible-option-cell">
 <div class="ansibleOptionAnchor" id="parameter-username"></div><p class="ansible-option-title" id="ansible-collections-community-routeros-api-module-parameter-username"><strong>username</strong></p>
 <a class="ansibleOptionLink" href="#parameter-username" title="Permalink to this option"></a><p class="ansible-option-type-line"><span class="ansible-option-type">string</span> / <span class="ansible-option-required">required</span></p>
 </div></td>
 <td><div class="ansible-option-cell"><p>RouterOS login user.</p>
 </div></td>
 </tr>
-<tr class="row-odd"><td><div class="ansible-option-cell">
+<tr class="row-even"><td><div class="ansible-option-cell">
 <div class="ansibleOptionAnchor" id="parameter-validate_cert_hostname"></div><p class="ansible-option-title" id="ansible-collections-community-routeros-api-module-parameter-validate-cert-hostname"><strong>validate_cert_hostname</strong></p>
 <a class="ansibleOptionLink" href="#parameter-validate_cert_hostname" title="Permalink to this option"></a><p class="ansible-option-type-line"><span class="ansible-option-type">boolean</span></p>
 <p><span class="ansible-option-versionadded">added in 1.2.0 of community.routeros</span></p>
@@ -408,7 +417,7 @@ see <a class="reference internal" href="#ansible-collections-community-routeros-
 </ul>
 </div></td>
 </tr>
-<tr class="row-even"><td><div class="ansible-option-cell">
+<tr class="row-odd"><td><div class="ansible-option-cell">
 <div class="ansibleOptionAnchor" id="parameter-validate_certs"></div><p class="ansible-option-title" id="ansible-collections-community-routeros-api-module-parameter-validate-certs"><strong>validate_certs</strong></p>
 <a class="ansibleOptionLink" href="#parameter-validate_certs" title="Permalink to this option"></a><p class="ansible-option-type-line"><span class="ansible-option-type">boolean</span></p>
 <p><span class="ansible-option-versionadded">added in 1.2.0 of community.routeros</span></p>

felixfontein

Thanks for your contribution! Could you please add a changelog fragment? Thanks.

plugins/doc_fragments/api.py

plugins/module_utils/api.py

codecov · 2022-08-31T16:18:36Z

Codecov Report

Merging #109 (adc1bb2) into main (47bbf95) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #109   +/-   ##
=======================================
  Coverage   86.52%   86.52%           
=======================================
  Files          29       29           
  Lines        3548     3548           
  Branches      666      666           
=======================================
  Hits         3070     3070           
  Misses        349      349           
  Partials      129      129

Flag	Coverage Δ
integration	`66.86% <ø> (ø)`
sanity	`22.03% <100.00%> (ø)`
units	`86.58% <100.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
plugins/doc_fragments/api.py	`100.00% <ø> (ø)`
plugins/module_utils/api.py	`39.13% <100.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

NikolayDachev · 2022-08-31T20:01:25Z

@TobsA13 @felixfontein,
I will try to find a time to do review as well until end of this week.
Regards,

@TobsA13 Thank you for contribution!

TobsA13 · 2022-09-01T08:28:06Z

@felixfontein Thank you. Added you suggestions. Sorry my first commit to an ansible module.

@NikolayDachev Nice. I am looking forward to your review.

felixfontein

One more comment.

Sorry my first commit to an ansible module.

Don't worry, everyone has to start at some point ;) We're here to help you polishing it.

changelogs/fragments/109-add-timeout-parameter-to-api.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

changelogs/fragments/109-add-timeout-parameter-to-api.yml

NikolayDachev

good to go and from my side

felixfontein · 2022-09-07T19:10:30Z

@TobsA13 thanks for your contribution!
@NikolayDachev thanks for reviewing this!

Added timeout setting for api.

0cb214b

felixfontein reviewed Aug 31, 2022

View reviewed changes

plugins/doc_fragments/api.py Show resolved Hide resolved

plugins/module_utils/api.py Outdated Show resolved Hide resolved

TobsA13 added 3 commits September 1, 2022 10:15

Added changelog fragment

cb32669

Added "version_added" to api doc

9ca1361

Added "," for better diff

58483ab

felixfontein reviewed Sep 3, 2022

View reviewed changes

changelogs/fragments/109-add-timeout-parameter-to-api.yml Outdated Show resolved Hide resolved

Fixed case and punctuation in changelog

1969795

Co-authored-by: Felix Fontein <felix@fontein.de>

felixfontein reviewed Sep 4, 2022

View reviewed changes

changelogs/fragments/109-add-timeout-parameter-to-api.yml Outdated Show resolved Hide resolved

Fixed url in changelog fragment

adc1bb2

felixfontein approved these changes Sep 5, 2022

View reviewed changes

NikolayDachev approved these changes Sep 7, 2022

View reviewed changes

felixfontein merged commit 776b599 into ansible-collections:main Sep 7, 2022

wyoa-bot bot mentioned this pull request Sep 11, 2022

feat(ansible): update community.routeros to 2.3.0 jr0dd/home-ops#1394

Merged

1 task

renovate bot mentioned this pull request Oct 3, 2022

feat(ansible-collection): update community.routeros to 2.5.0 - autoclosed anthr76/infra#1612

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added timeout setting for api. #109

Added timeout setting for api. #109

TobsA13 commented Aug 31, 2022

github-actions bot commented Aug 31, 2022 •

edited

Loading

felixfontein left a comment

codecov bot commented Aug 31, 2022 •

edited

Loading

NikolayDachev commented Aug 31, 2022

TobsA13 commented Sep 1, 2022

felixfontein left a comment

NikolayDachev left a comment

felixfontein commented Sep 7, 2022

Added timeout setting for api. #109

Added timeout setting for api. #109

Conversation

TobsA13 commented Aug 31, 2022

Added timeout setting for the API request.

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

github-actions bot commented Aug 31, 2022 • edited Loading

Docs Build 📝

felixfontein left a comment

Choose a reason for hiding this comment

codecov bot commented Aug 31, 2022 • edited Loading

Codecov Report

NikolayDachev commented Aug 31, 2022

TobsA13 commented Sep 1, 2022

felixfontein left a comment

Choose a reason for hiding this comment

NikolayDachev left a comment

Choose a reason for hiding this comment

felixfontein commented Sep 7, 2022

github-actions bot commented Aug 31, 2022 •

edited

Loading

codecov bot commented Aug 31, 2022 •

edited

Loading