Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for additional API paths #125

Merged
merged 9 commits into from
Nov 12, 2022

Conversation

therfert
Copy link
Contributor

@therfert therfert commented Nov 10, 2022

SUMMARY

api_modify, api_info - support API paths:

  • interface pppoe-client
  • interface vlan
  • interface bridge vlan
  • interface bridge

Default value fix of interface bridge port ingress-filtering according to the default in ROS

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • api_modify
  • api_info
ADDITIONAL INFORMATION

none

Tomas Herfert added 3 commits November 10, 2022 23:39
Signed-off-by: Tomas Herfert <herfik>
Signed-off-by: Tomas Herfert <herfik>
Signed-off-by: Tomas Herfert <herfik>
@therfert therfert changed the title Paths Support for additional API paths Nov 10, 2022
Signed-off-by: Tomas Herfert <herfik>
@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #125 (22b6c7b) into main (9567bbf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #125   +/-   ##
=======================================
  Coverage   87.56%   87.56%           
=======================================
  Files          28       28           
  Lines        3499     3499           
  Branches      619      619           
=======================================
  Hits         3064     3064           
  Misses        308      308           
  Partials      127      127           
Flag Coverage Δ
integration 66.86% <ø> (ø)
sanity 22.45% <ø> (ø)
units 87.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/module_utils/_api_data.py 95.91% <ø> (ø)
plugins/modules/api_info.py 89.23% <ø> (ø)
plugins/modules/api_modify.py 79.90% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

github-actions bot commented Nov 10, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

Tomas Herfert added 2 commits November 11, 2022 00:40
Signed-off-by: Tomas Herfert <herfik>
…port ingress-filtering to True

Signed-off-by: Tomas Herfert <herfik>
@therfert therfert marked this pull request as ready for review November 11, 2022 10:46
Tomas Herfert and others added 2 commits November 12, 2022 10:10
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more tiny thing :)

changelogs/fragments/125-api.yml Outdated Show resolved Hide resolved
Co-authored-by: Felix Fontein <felix@fontein.de>
@felixfontein felixfontein merged commit ad9d7c3 into ansible-collections:main Nov 12, 2022
@felixfontein
Copy link
Collaborator

@therfert thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants