Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "ip firewall layer7-protocol" #153

Merged
merged 3 commits into from
Feb 27, 2023
Merged

Add support for "ip firewall layer7-protocol" #153

merged 3 commits into from
Feb 27, 2023

Conversation

phox142
Copy link
Contributor

@phox142 phox142 commented Feb 27, 2023

SUMMARY

Add support for API paths "ip firewall layer7-protocol"

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ip firewall layer7-protocol

@github-actions
Copy link

github-actions bot commented Feb 27, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://ansible-collections.github.io/community.routeros/branch/main

Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me. Can you please add a changelog fragment? Thanks.

@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #153 (54e649b) into main (bbf5be5) will decrease coverage by 19.04%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #153       +/-   ##
===========================================
- Coverage   86.47%   67.44%   -19.04%     
===========================================
  Files          30        2       -28     
  Lines        3690      172     -3518     
  Branches      673       39      -634     
===========================================
- Hits         3191      116     -3075     
+ Misses        362       40      -322     
+ Partials      137       16      -121     
Flag Coverage Δ
integration 66.86% <ø> (ø)
sanity ?
units ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/module_utils/quoting.py 62.41% <0.00%> (-37.59%) ⬇️
plugins/module_utils/_api_data.py
plugins/modules/api_info.py
plugins/modules/api_modify.py
plugins/modules/api_find_and_modify.py
tests/unit/plugins/modules/test_command.py
plugins/module_utils/routeros.py
tests/unit/plugins/modules/fake_api.py
plugins/terminal/routeros.py
plugins/cliconf/routeros.py
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@felixfontein felixfontein merged commit ab87a27 into ansible-collections:main Feb 27, 2023
@felixfontein
Copy link
Collaborator

@phox142 thanks for implementing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants