Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'routing rule' path #246

Merged

Conversation

derdeagle
Copy link
Contributor

SUMMARY

Add the routing rule path for #162 .

In the issue the path routing table was requested but this was added with PR #215 . Somewhere in the depths of the MikroTik documentation I read that routing table would only make limited sense without routing rule but I cannot find it anymore.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • api_info
  • api_modify
ADDITIONAL INFORMATION

None.

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1d6feda) 82.97% compared to head (f083902) 82.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #246   +/-   ##
=======================================
  Coverage   82.97%   82.97%           
=======================================
  Files          32       32           
  Lines        4046     4046           
  Branches      871      871           
=======================================
  Hits         3357     3357           
  Misses        506      506           
  Partials      183      183           
Flag Coverage Δ
integration 66.86% <ø> (ø)
sanity 22.10% <ø> (ø)
units 82.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 28, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://ansible-collections.github.io/community.routeros/branch/main

@felixfontein felixfontein merged commit 79dabbb into ansible-collections:main Jan 6, 2024
45 checks passed
@felixfontein
Copy link
Collaborator

@derdeagle thanks for adding this!

@derdeagle derdeagle deleted the 162-routing-rule-path branch January 6, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants