Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 'ppp secret' path #286

Merged
merged 2 commits into from
May 18, 2024

Conversation

samburney
Copy link
Contributor

SUMMARY

Add support for 'ppp secret' path

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • api_info
  • api_modify

Copy link

github-actions bot commented May 13, 2024

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://ansible-collections.github.io/community.routeros/branch/main

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.99%. Comparing base (3862d1c) to head (35b081d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #286      +/-   ##
==========================================
+ Coverage   82.97%   82.99%   +0.01%     
==========================================
  Files          32       32              
  Lines        4048     4051       +3     
  Branches      663      873     +210     
==========================================
+ Hits         3359     3362       +3     
  Misses        506      506              
  Partials      183      183              
Flag Coverage Δ
integration 66.86% <ø> (ø)
sanity 22.08% <ø> (ø)
units 82.93% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samburney samburney marked this pull request as ready for review May 13, 2024 10:11
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@felixfontein felixfontein merged commit 331a97b into ansible-collections:main May 18, 2024
49 checks passed
@felixfontein
Copy link
Collaborator

@samburney thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants