Fix query #68
Merged
Fix query #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #68 +/- ##
=======================================
Coverage 82.42% 82.42%
=======================================
Files 16 16
Lines 1542 1542
Branches 203 203
=======================================
Hits 1271 1271
Misses 217 217
Partials 54 54
Continue to review full report at Codecov.
|
|
Folks, please review This is a small fix for #67 (legacy code) |
felixfontein
reviewed
Feb 8, 2022
Co-authored-by: Felix Fontein <felix@fontein.de>
felixfontein
approved these changes
Feb 8, 2022
Backport to stable-1: 💚 backport PR created✅ Backport PR branch: Backported as #69 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Feb 10, 2022
* fix issues #67 * fix query id check * add changelog fragment * fix changelog fragment new line * fix changelog fragment new line2 * Update changelogs/fragments/68-fix-query-id-check.yml Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit a46c7df)
|
@NikolayDachev thanks a lot for fixing this! |
felixfontein
pushed a commit
that referenced
this pull request
Feb 10, 2022
* fix issues #67 * fix query id check * add changelog fragment * fix changelog fragment new line * fix changelog fragment new line2 * Update changelogs/fragments/68-fix-query-id-check.yml Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit a46c7df) Co-authored-by: Nikolay Dachev <nikolay@dachev.info>
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Include Fixes #67
ISSUE TYPE
COMPONENT NAME
api module
ADDITIONAL INFORMATION
Fix ".id" check in api_query()
Fix query docs (query is not limited to return .id!)