-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix query #68
Fix query #68
Conversation
Codecov Report
@@ Coverage Diff @@
## main #68 +/- ##
=======================================
Coverage 82.42% 82.42%
=======================================
Files 16 16
Lines 1542 1542
Branches 203 203
=======================================
Hits 1271 1271
Misses 217 217
Partials 54 54
Continue to review full report at Codecov.
|
Folks, please review This is a small fix for #67 (legacy code) |
Co-authored-by: Felix Fontein <felix@fontein.de>
Backport to stable-1: 💚 backport PR created✅ Backport PR branch: Backported as #69 🤖 @patchback |
* fix issues #67 * fix query id check * add changelog fragment * fix changelog fragment new line * fix changelog fragment new line2 * Update changelogs/fragments/68-fix-query-id-check.yml Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit a46c7df)
@NikolayDachev thanks a lot for fixing this! |
* fix issues #67 * fix query id check * add changelog fragment * fix changelog fragment new line * fix changelog fragment new line2 * Update changelogs/fragments/68-fix-query-id-check.yml Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit a46c7df) Co-authored-by: Nikolay Dachev <nikolay@dachev.info>
SUMMARY
Include Fixes #67
ISSUE TYPE
COMPONENT NAME
api module
ADDITIONAL INFORMATION
Fix ".id" check in api_query()
Fix query docs (query is not limited to return .id!)