Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle escape sequence \_ correctly #89

Merged
merged 1 commit into from
May 9, 2022

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

\_ means a quoted space, not a quoted underscore.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

(un)quoting filters
api module

@codecov
Copy link

codecov bot commented May 7, 2022

Codecov Report

Merging #89 (2438811) into main (02ecc0c) will decrease coverage by 49.53%.
The diff coverage is 100.00%.

❗ Current head 2438811 differs from pull request most recent head d6db300. Consider uploading reports for the commit d6db300 to get more accurate results

@@             Coverage Diff             @@
##             main      #89       +/-   ##
===========================================
- Coverage   82.39%   32.85%   -49.54%     
===========================================
  Files          16        8        -8     
  Lines        1545      913      -632     
  Branches      247      184       -63     
===========================================
- Hits         1273      300      -973     
- Misses        218      597      +379     
+ Partials       54       16       -38     
Impacted Files Coverage Δ
plugins/module_utils/quoting.py 62.41% <100.00%> (-37.59%) ⬇️
plugins/modules/facts.py 21.81% <0.00%> (-61.19%) ⬇️
plugins/modules/command.py 41.66% <0.00%> (-56.25%) ⬇️
plugins/modules/api.py 19.68% <0.00%> (-51.30%) ⬇️
tests/unit/plugins/module_utils/test_quoting.py
tests/unit/plugins/modules/utils.py
tests/unit/plugins/modules/test_facts.py
tests/unit/plugins/modules/routeros_module.py
tests/unit/compat/mock.py
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02ecc0c...d6db300. Read the comment docs.

@felixfontein
Copy link
Collaborator Author

Ok, tests are passing now :)

Copy link
Collaborator

@NikolayDachev NikolayDachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick test look ok, also this is tested in integ/unit tests as well

@felixfontein felixfontein merged commit a90c696 into ansible-collections:main May 9, 2022
@felixfontein felixfontein deleted the quote-_ branch May 9, 2022 20:09
@felixfontein
Copy link
Collaborator Author

@NikolayDachev thanks for reviewing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants