vmware_vm_inventory - fixed hostgroups being created automatically when the with_path option is enabled

[dmnagornyi]

SUMMARY

Fixes #1688
Plugin should not create hostgroups automatically when with_path is true. There is keyed_groups parameter for that.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

community.vmware.vmware_vm_inventory

ADDITIONAL INFORMATION

I just removed a block of code that performed an undocumented function and generated a lot of unnecessary hostgroups.

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/89e1a4eaf0fd4a8f94bda9d1d0a6d374

❌ ansible-tox-linters FAILURE in 4m 31s
⚠️ build-ansible-collection CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_only-stable217 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable217 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable217_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable217_2_of_2 CANCELED
⚠️ ansible-galaxy-importer CANCELED

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/710035b81df94ec68d1b6905a8a0e11e

✔️ ansible-tox-linters SUCCESS in 5m 08s
✔️ build-ansible-collection SUCCESS in 7m 25s
✔️ ansible-test-cloud-integration-vcenter7_only-stable217 SUCCESS in 21m 24s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable217 SUCCESS in 19m 12s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable217_1_of_2 FAILURE in 1h 01m 50s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable217_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 5m 07s

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/ecac06fa2bbc4ceaa017753f63a621a6

✔️ ansible-tox-linters SUCCESS in 4m 28s
✔️ build-ansible-collection SUCCESS in 7m 23s
✔️ ansible-test-cloud-integration-vcenter7_only-stable217 SUCCESS in 21m 20s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable217 SUCCESS in 18m 58s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable217_1_of_2 SUCCESS in 45m 55s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable217_2_of_2 SUCCESS in 1h 18m 01s
✔️ ansible-galaxy-importer SUCCESS in 3m 18s

[dmnagornyi]

@mariolenz please take a look when you have a chance. Minimal changes, shouldn't interfere with anything.

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/0a83eb601d134e16ab172fee0be2d21b

✔️ ansible-tox-linters SUCCESS in 4m 53s
✔️ build-ansible-collection SUCCESS in 7m 43s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable218 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 FAILURE in 14m 55s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 4m 53s

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/076235766f954a05b614f929bd749e3f

✔️ ansible-tox-linters SUCCESS in 4m 32s
✔️ build-ansible-collection SUCCESS in 7m 31s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable218 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 FAILURE in 14m 34s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 5m 06s

[mariolenz]

recheck

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/7fa2f04c67424ec383e4b4e86f1a6739

✔️ ansible-tox-linters SUCCESS in 4m 21s
✔️ build-ansible-collection SUCCESS in 7m 38s
✔️ ansible-test-cloud-integration-vcenter7_only-stable218 SUCCESS in 22m 05s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 SUCCESS in 20m 51s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 SUCCESS in 52m 57s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 SUCCESS in 55m 27s
✔️ ansible-galaxy-importer SUCCESS in 6m 15s

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/0b661f5d55eb415290fbf05621067b23

✔️ ansible-tox-linters SUCCESS in 5m 40s
✔️ build-ansible-collection SUCCESS in 7m 20s
✔️ ansible-test-cloud-integration-vcenter7_only-stable218 SUCCESS in 21m 09s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 SUCCESS in 17m 25s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 SUCCESS in 53m 52s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 SUCCESS in 58m 52s
✔️ ansible-galaxy-importer SUCCESS in 3m 04s

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/35d1bad04983446f9d8017bc913f9ab5

✔️ ansible-tox-linters SUCCESS in 4m 52s
✔️ build-ansible-collection SUCCESS in 7m 57s
✔️ ansible-test-cloud-integration-vcenter7_only-stable218 SUCCESS in 16m 41s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 SUCCESS in 14m 48s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 SUCCESS in 1h 03m 35s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 SUCCESS in 46m 07s
✔️ ansible-galaxy-importer SUCCESS in 6m 00s

[dmnagornyi]

recheck

Anything else I need to do?

[mariolenz]

I'm sorry, I didn't find much time to work on this collection during the last weeks. I hope I'm able to review this PR soon.

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/5211ee40b6a347c39d49354c91453fe5

✔️ ansible-tox-linters SUCCESS in 5m 19s
✔️ build-ansible-collection SUCCESS in 8m 10s
✔️ ansible-test-cloud-integration-vcenter7_only-stable218 SUCCESS in 23m 24s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 SUCCESS in 13m 20s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 SUCCESS in 59m 21s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 SUCCESS in 44m 49s
✔️ ansible-galaxy-importer SUCCESS in 3m 07s

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/f203f014c1474d379784fbb833bc0725

✔️ ansible-tox-linters SUCCESS in 4m 42s
✔️ build-ansible-collection SUCCESS in 7m 19s
✔️ ansible-test-cloud-integration-vcenter7_only-stable218 SUCCESS in 22m 55s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 SUCCESS in 20m 23s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 SUCCESS in 59m 18s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 SUCCESS in 54m 27s
✔️ ansible-galaxy-importer SUCCESS in 5m 04s

[mariolenz]

Thanks very much for your contribution, but I'm not sure if we merge this because

1. even if the documentation says otherwise, the plugin has worked like this for ages and your change might break things for users who rely on it working as it does
2. I've never really understood those integration plugins :-/
3. there's now a vms inventory plugin in vmware.vmware 1.9.0
4. because of 2 and 3 I'm about to deprecate vmware_vm_inventory, anyway: [WIP] Deprecate inventory plugins #2283

If this isn't very important for you, I suggest to close this PR and not merge it. If you really want to have this, I'll try to understand more but this might take some time (see 2 above).