Quality of life improvements for zabbix server role #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyrodie18
reviewed
May 17, 2024
galaxy.yml
Outdated
| @@ -24,4 +24,4 @@ dependencies: | |||
| ansible.posix: "*" | |||
| community.general: "*" | |||
| community.mysql: "*" | |||
| community.postgresql: "*" | |||
| community.postgresql: ">=2.0.0" | |||
There was a problem hiding this comment.
Is there a reason for this change? This would be a breaking change.
There was a problem hiding this comment.
Not really, no. It's just as far back as I tested the collection. I went to galaxy to find the earliest version, 0.1.0. And that seems to work. Will undo this pinning.
Empty defaults just create problems with common ansible conventions, and is generally not a good practice.
Coming up in community.postgresql 4.0.0 using priv with the postgresql_user be removed, and we are encouraged already now to start using the postgresql_privs module. This should also take care of some outstanding issues with installing on postgres-15 (ansible-collections#928)
Much like the postgres user has carte blanche access to postgresql database, the root user has to mysql databases over the mysql.sock. We can use become when zabbix_server_dbhost_run_install: true in a similar fashion. Provide the default port for database servers. This could have been an if-statement, I just don't like the "looseness" of the else part. So I opted for a lookup-table.
There's no testing against python2 anymore, nor zabbix-5.0. So lets lighten the load by removing this baggage.
pyrodie18
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Quality of life improvements for zabbix server role
ISSUE TYPE
COMPONENT NAME
zabbix_server role
ADDITIONAL INFORMATION
I created a Vagrantfile to just test the most basic, common way I can see this role deployed for mysql and pgsql variants, and these are the remaining fixes I needed to deploy the role.
The most common setup being OS with either postgresql or mysql/mariadb installed, and installing zabbix_server to it with the default localhost connection to the database.