Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add defaults, documentation entry for the var zabbix_apache_custom_includes #986

Conversation

mcbrineellis
Copy link
Contributor

SUMMARY

The variable appears to have been accidentally removed in the final 2.0.0 tag release.
I've readded it to what I believe to be the appropriate locations.

Fixes #985

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

TASK [community.zabbix.zabbix_web : Apache | Install apache vhost]

Copy link
Collaborator

@pyrodie18 pyrodie18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcbrineellis , What does that variable tie back to? I don't see it used anywhere in 2.0.0 and looking back, I can't see it in the last 1.X release either.

@mcbrineellis
Copy link
Contributor Author

@pyrodie18 it was added in #935 and it's still present in the 2.0.0 release roles/zabbix_web/templates/apache_vhost.conf.j2 but was removed elsewhere.

So the issue I opened is because without the default of [], it errors that the var is undefined.

@pyrodie18
Copy link
Collaborator

Ya I just realized I had a filter in place when I did a search so it wasn't checking the .j2 files. I'm slightly surprised it didn't error our in our testing though because it should have.

@BGmot
Copy link
Collaborator

BGmot commented May 14, 2023

@mcbrineellis please make following changes, after that molecule tests should go through.

diff --git a/molecule/requirements.txt b/molecule/requirements.txt
index bec205a..7b0bc88 100644
--- a/molecule/requirements.txt
+++ b/molecule/requirements.txt
@@ -1,11 +1,13 @@
 # Install CI dependencies for the Zabbix Roles
 ansible==7.0.0
-ansible-compat==0.5.0
+ansible-compat==3.0.0
 ansible-core==2.14.2
-docker==5.0.2
-molecule==3.5.1
-molecule-docker==1.0.2
+docker==6.0.1
+molecule==4.0.4
+molecule-docker==2.1.0
 netaddr==0.8.0
-pytest-testinfra==6.1.0
+pytest==7.2.1
+pytest-testinfra==7.0.0
 ipaddr==2.2.0
 ipaddress==1.0.23
+requests==2.28.2

@pyrodie18
Copy link
Collaborator

@mcbrineellis I'm about to push @BGmot changes to the repo in a few minutes once my current tests run and it should trickle down to you.

@pyrodie18 pyrodie18 merged commit ebc456c into ansible-collections:main May 15, 2023
@mcbrineellis mcbrineellis deleted the fix-985-zabbix_apache_custom_includes branch May 15, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zabbix Web fails on "Install apache vhost" when zabbix_apache_custom_includes is undefined
3 participants