auth: Support for GCP access tokens #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Introduce choice "accesstoken" for auth_kind for modules * Introduce optional access_token string param that falls back to GCP_ACCESS_TOKEN env var
|
Thanks! sounds good. I'll add the changelog fragment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Partly addresses #465.
Fixes #486.
ISSUE TYPE
ADDITIONAL INFORMATION
I have tested this myself, but didn't try to write any tests since they'd require an actual GCP token to be meaningful. I also didn't understand how changelog fragments work so I left that out.