Nazare 8838 force option #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddimatos
added
Enhancement
#346) * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * This function updates the existing code to leverage the latest API changes available in ZOAU 1.2.0 (#312) * zos_operator: removed rexx/sdsf script and used opercmd.execute() instead ... this passes integration/playbook tests, ... so I'm duplicating the change in job.py before build testing * Initial branch for Jira NAZARE-6933... this aligns zos_submit/zos_output to zoau. We use the zoau library instead of a local rexx and sdsf call. Note: passes integration tests using 1.2 of zoau. Note: documentation is mistaken, which I'll change before PR submission * NAZARE-6933 (alignment with zoau) - code complete Unit tests pass, with 3 variances: 1 - Cannot find/get Job class 2 - Cannot find/get content_type 3 - msg_txt is what is returned from job list, so it's not as meaningful as the sdsf version was. * update to pull class, system and subsystem from the dd's when loading job. still haven't found job type outside of sdsf. * Corrected processing of the 'node' value for subsystem. Upcoming: found an odd response on JCL error. * error handling: added "JCLERR" to list of terminators error handling: no return error code as rc where appropriate (from dd) non-error handling: added a check to not consider a job status provided if the dd's aren't there * comment in zos_job_output hadn't been saved * removed other comment, since the issue was addressed. * fixes for pep-8 issues (spacing) tweak to switch IFSDELAY (SDSF) to use timeout (zoau native) * Tweaking import statements to add some protection to zoau imports. * correction to call of _zget_job_status (had self-referenced a parameter) * experimental change to zget_job_status::jobs/listing, to only pass first param This is to check a theory that the additional owner param for 1.2 is killing 1.1 testing * Added sdsf action back into zos_operator so that 1.1 zoau could pass the timer test * added TJSP to output to track error in job_submit_func * added traccking to test_zos_operator_func (test precedence keeps changing) * tweak to handle 1.1 situation where ddls doesn't return a recnum * bugfix: run_operator_command needed to use wait_time_s, not wait_time * tracking with output added to time delay test of operator func * pep8 fixes on a test function (?>?!) * expanded error handling in job.poy to handle partial returns from listing and list_dds * changed if not ... in ... to if ... not in ... ... argh * tweaked test for more output, and temporarily commented assertion. * fixing argument indext * yet another pylint issue on a test message * change to add parameter back into operator call change to add time assertion back into operator test * changed operator command delay param, but re-commented assertion This will pass, but delay doesn't seem to be working. * job: put in logic to limit result based on ddname, if provided output: removed excess operator: corrected parameter passing * change to import to get past linter * forgot missingImport import * Change to job to handle ddname value... same for job_query. * Adding changelog fragement to the pull request Signed-off-by: ddimatos <dimatos@gmail.com> * Update the branch enh6933 used for pull request 312 by merging in the latest from branch dev. (#338) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Rich Parker <richp405@gmail.com> * added changes from PR comments: job.py: cleaned up variable name, stray comment, switched some n/a and UNAV to None zos_job_submit: improved wording on an exception message Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Feature/2621/regex operator action query (#313) * added message_text parameter for specifying a regex * Added new parameter documentation and example * Simplified regex pattern * Revert "Simplified regex pattern" This reverts commit a877b9d59465016fad78f9c0e1c594b576a00fff. Going back to using all valid regex to parse the raw output from z/OS * Added regex to raw message * Changed 'msg_' to 'message_' to keep consistency * Added tests for regex * Changed description for message_text in RETURN doc * Added use_regex suboption to message_filter * Fixed documentation style issues * Updated tests for new suboption in zos_operator_action_query * Added test cases for use_regex and tweaked examples * Doc/regex operator action query (#340) * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * This function updates the existing code to leverage the latest API changes available in ZOAU 1.2.0 (#312) * zos_operator: removed rexx/sdsf script and used opercmd.execute() instead ... this passes integration/playbook tests, ... so I'm duplicating the change in job.py before build testing * Initial branch for Jira NAZARE-6933... this aligns zos_submit/zos_output to zoau. We use the zoau library instead of a local rexx and sdsf call. Note: passes integration tests using 1.2 of zoau. Note: documentation is mistaken, which I'll change before PR submission * NAZARE-6933 (alignment with zoau) - code complete Unit tests pass, with 3 variances: 1 - Cannot find/get Job class 2 - Cannot find/get content_type 3 - msg_txt is what is returned from job list, so it's not as meaningful as the sdsf version was. * update to pull class, system and subsystem from the dd's when loading job. still haven't found job type outside of sdsf. * Corrected processing of the 'node' value for subsystem. Upcoming: found an odd response on JCL error. * error handling: added "JCLERR" to list of terminators error handling: no return error code as rc where appropriate (from dd) non-error handling: added a check to not consider a job status provided if the dd's aren't there * comment in zos_job_output hadn't been saved * removed other comment, since the issue was addressed. * fixes for pep-8 issues (spacing) tweak to switch IFSDELAY (SDSF) to use timeout (zoau native) * Tweaking import statements to add some protection to zoau imports. * correction to call of _zget_job_status (had self-referenced a parameter) * experimental change to zget_job_status::jobs/listing, to only pass first param This is to check a theory that the additional owner param for 1.2 is killing 1.1 testing * Added sdsf action back into zos_operator so that 1.1 zoau could pass the timer test * added TJSP to output to track error in job_submit_func * added traccking to test_zos_operator_func (test precedence keeps changing) * tweak to handle 1.1 situation where ddls doesn't return a recnum * bugfix: run_operator_command needed to use wait_time_s, not wait_time * tracking with output added to time delay test of operator func * pep8 fixes on a test function (?>?!) * expanded error handling in job.poy to handle partial returns from listing and list_dds * changed if not ... in ... to if ... not in ... ... argh * tweaked test for more output, and temporarily commented assertion. * fixing argument indext * yet another pylint issue on a test message * change to add parameter back into operator call change to add time assertion back into operator test * changed operator command delay param, but re-commented assertion This will pass, but delay doesn't seem to be working. * job: put in logic to limit result based on ddname, if provided output: removed excess operator: corrected parameter passing * change to import to get past linter * forgot missingImport import * Change to job to handle ddname value... same for job_query. * Adding changelog fragement to the pull request Signed-off-by: ddimatos <dimatos@gmail.com> * Update the branch enh6933 used for pull request 312 by merging in the latest from branch dev. (#338) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Rich Parker <richp405@gmail.com> * added changes from PR comments: job.py: cleaned up variable name, stray comment, switched some n/a and UNAV to None zos_job_submit: improved wording on an exception message Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Rich Parker <richp405@gmail.com> * Minor doc updates per the pull request comments Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Demetri <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Rich Parker <richp405@gmail.com> * Nazare 8880 prepend spaces (#317) * Added indentation option to the module * Added blockinfile tests and modified helper to assert taking into account spaces and line breaks * Add changelog frament to release. Signed-off-by: ddimatos <dimatos@gmail.com> * Merge dev into NAZARE-8880-prepend-spaces to handle the divergence (#342) * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * This function updates the existing code to leverage the latest API changes available in ZOAU 1.2.0 (#312) * zos_operator: removed rexx/sdsf script and used opercmd.execute() instead ... this passes integration/playbook tests, ... so I'm duplicating the change in job.py before build testing * Initial branch for Jira NAZARE-6933... this aligns zos_submit/zos_output to zoau. We use the zoau library instead of a local rexx and sdsf call. Note: passes integration tests using 1.2 of zoau. Note: documentation is mistaken, which I'll change before PR submission * NAZARE-6933 (alignment with zoau) - code complete Unit tests pass, with 3 variances: 1 - Cannot find/get Job class 2 - Cannot find/get content_type 3 - msg_txt is what is returned from job list, so it's not as meaningful as the sdsf version was. * update to pull class, system and subsystem from the dd's when loading job. still haven't found job type outside of sdsf. * Corrected processing of the 'node' value for subsystem. Upcoming: found an odd response on JCL error. * error handling: added "JCLERR" to list of terminators error handling: no return error code as rc where appropriate (from dd) non-error handling: added a check to not consider a job status provided if the dd's aren't there * comment in zos_job_output hadn't been saved * removed other comment, since the issue was addressed. * fixes for pep-8 issues (spacing) tweak to switch IFSDELAY (SDSF) to use timeout (zoau native) * Tweaking import statements to add some protection to zoau imports. * correction to call of _zget_job_status (had self-referenced a parameter) * experimental change to zget_job_status::jobs/listing, to only pass first param This is to check a theory that the additional owner param for 1.2 is killing 1.1 testing * Added sdsf action back into zos_operator so that 1.1 zoau could pass the timer test * added TJSP to output to track error in job_submit_func * added traccking to test_zos_operator_func (test precedence keeps changing) * tweak to handle 1.1 situation where ddls doesn't return a recnum * bugfix: run_operator_command needed to use wait_time_s, not wait_time * tracking with output added to time delay test of operator func * pep8 fixes on a test function (?>?!) * expanded error handling in job.poy to handle partial returns from listing and list_dds * changed if not ... in ... to if ... not in ... ... argh * tweaked test for more output, and temporarily commented assertion. * fixing argument indext * yet another pylint issue on a test message * change to add parameter back into operator call change to add time assertion back into operator test * changed operator command delay param, but re-commented assertion This will pass, but delay doesn't seem to be working. * job: put in logic to limit result based on ddname, if provided output: removed excess operator: corrected parameter passing * change to import to get past linter * forgot missingImport import * Change to job to handle ddname value... same for job_query. * Adding changelog fragement to the pull request Signed-off-by: ddimatos <dimatos@gmail.com> * Update the branch enh6933 used for pull request 312 by merging in the latest from branch dev. (#338) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Gh issue 329 ddname (#333) * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: ddimatos <dimatos@gmail.com> * Update zos_blockinfile to correctly manage double quotes in the block (#303) * Changed the quotedString routine to remove double-quotations instead of escaping them. Because this routine is potentially called multiple times, the escaping can become problematic. Also, the quotation marks themselves cause problems with the zoau/blockinfile routine that gets called. * Added note to documentation that quotation marks will be removed. * Added 4.2 ignore file * added 2.13 ignore * added more ignore files, in case the versioning is butchered (added 4.0 and 4.1) * removed some ignore files, and mucked 2.11 up to see if it throws an error * added ignore 12, 13 and put different garbage in each...trying to find which ignore is used * messed up the 4.2 ignore file * added 2.11.5 ignore, still looking for the trigger * added ignore.txt, in case 2.13 is being skipped * removed incorrect ignore files. * restored ignore files * Added changelog fragement for pr 303 Signed-off-by: ddimatos <dimatos@gmail.com> * Udpate the changelog fragment with more details Signed-off-by: ddimatos <dimatos@gmail.com> * Doc/pr303/add changelog to branch (#337) * Copy ignore-2.12.txt to ignore-2.13.txt * Update/copy fetch scp bypass (#305) * Update galaxy author list Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Add logic to ensure the module only uses SFTP for sftp_transfer_method so that encodings are maintained as desired Signed-off-by: ddimatos <dimatos@gmail.com> * Sanity tests: copy ignore-2.13.txt to ignore-2.14.txt * Update dependency to use the latest with security patches (#332) * Update dependency to use the latest with security patches Signed-off-by: ddimatos <dimatos@gmail.com> * Update requirements to community 4.10.0 which is ansible-core 2.11.7 Signed-off-by: ddimatos <dimatos@gmail.com> * Revert "Update requirements to community 4.10.0 which is ansible-core 2.11.7" because our jenkins and docker images are not yet ready for what 4.10.0 brings in for dependencies. The last error for this migration shows that we need to add pycodestyle to our container. This reverts commit 9dfd29acc23d283c0aefb24e1a2c1774ff1b9b7c. * Fixed typo for dd_name that prevented job output filtering based on dd_name * Added functional tests to verify ddname filtering * Update Readme to reflect supported ansible version Signed-off-by: ddimatos <dimatos@gmail.com> * Upate release note to reflect patched version 1.3.x Signed-off-by: ddimatos <dimatos@gmail.com> * Update galaxy.yml with added build_ignore and authors Signed-off-by: ddimatos <dimatos@gmail.com> * Update artifacts to correctly reflect execution environments Signed-off-by: ddimatos <dimatos@gmail.com> * Update module with boolean bug fix and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update modules docs and version released Signed-off-by: ddimatos <dimatos@gmail.com> * Update error message for clarity Signed-off-by: ddimatos <dimatos@gmail.com> * Update sanity tests to remove a doc reference Signed-off-by: ddimatos <dimatos@gmail.com> * First commit for changelog support and backported release fragemetns Signed-off-by: ddimatos <dimatos@gmail.com> * Update changelog fragments because of yamlint blank lines Signed-off-by: ddimatos <dimatos@gmail.com> * update zos_fetch test case to remove testing the sftp port which is deprecated Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * update test case with verbosity to troubleshoot file count Signed-off-by: ddimatos <dimatos@gmail.com> * Update the test case to add 1 to the count for the added profile Signed-off-by: ddimatos <dimatos@gmail.com> * Correct missing whitespace around arithmetic operator Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * Chaning src file because I think there is a race condition where its used elsewhere Signed-off-by: ddimatos <dimatos@gmail.com> * add more debug stmt's to the test case Signed-off-by: ddimatos <dimatos@gmail.com> * Added more debug to the test Signed-off-by: ddimatos <dimatos@gmail.com> * Update test case with more debug Signed-off-by: ddimatos <dimatos@gmail.com> * udpate test case to correctly validate copied file Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> * Update fragment from bug fix to minor changes Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: ddimatos <dimatos@gmail.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Andrew Klychkov <aklychko@redhat.com> Co-authored-by: Fernando Flores <fflores10@uabc.edu.mx> Co-authored-by: Oscar Fernando Flores Garcia <fernando.flores@ibm.com> Co-authored-by: Rich Parker <richp405@gmail.com> * added changes from PR comments: job.py: cleaned up variable name, stray comment, switched some n/a and UNAV to None zos_job_submit: improved wording on…
Signed-off-by: ddimatos <dimatos@gmail.com>
Signed-off-by: ddimatos <dimatos@gmail.com>
ddimatos
approved these changes
Jul 1, 2022
There was a problem hiding this comment.
@fernandofloresg looks good, thanks for this update, added test cases are great. I made a few edits which I shared with you , merging this because currently the pipeline is set to a backlevel of zoau and I have already tested this with zoau 1.2. in the pipeline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Added a force option in the zos_blockinfile module.
The new force option is obtained as parameter, then parsed to have the '-f' option text, then sent into the present and absent functions as options keyword.
ISSUE TYPE
COMPONENT NAME
zos_blockinfile
ADDITIONAL INFORMATION