Bugfix/393/tmp hlq ddstatements: Adds tmphlq to create_temp datasets in DDStatements. #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# This is the 1st commit message: Added the tmphlq in a different funtion in case we need to set extra attributes in the future # This is the commit message #2: Fixing pep8 issues
…attributes in the future Fixing pep8 issues Updated dependency finder resolved pep8 issue
Added removed comma Pulled dependency finder Got latest dependency finder
fernandofloresg
requested review from
ketankelkar,
rexemin,
ddimatos and
richp405
|
|
|
Temporarily closed to add change log fragments. |
fernandofloresg
force-pushed
the
bugfix/393/tmp_hl-ddstatements
branch
from
64a339f to
f79c4fc
Compare
Added new line at the end of file Added new line at the end of file
fernandofloresg
force-pushed
the
bugfix/393/tmp_hl-ddstatements
branch
from
f79c4fc to
e6cc80f
Compare
ddimatos
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Discovered that during the implementation of tmphlq there were some missing DDStatements in zos_mvs_raw that were missing the tmphlq when calling Datasets.create_temp()
Added TMPHLQ as a parameter for StdinDefinition and OutputDefinition defaulting as an empty string, this is different as how tmphlq is defaulted to None in other sections of the code because the hlq parameter of create_temp is a string and defaults as empty too, so I wanted to keep consistency with that interface.
Also, since tmphlq was now added to more than dd type I abstracted the assignment into a function called set_extra_attributes_in_dd to avoid overpopulating the build_data_definition function with tmphlq assignments, figured that we could add extra attributes there too if needed in the future(maybe pass it as kwargs to add into the dds).
Fixes #393
ISSUE TYPE
COMPONENT NAME
zos_mvs_raw
ADDITIONAL INFORMATION