Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix zos_mount module where ccsid should have been a string type #502

Merged
merged 12 commits into from
Oct 5, 2022
Merged

Bugfix zos_mount module where ccsid should have been a string type #502

merged 12 commits into from
Oct 5, 2022

Conversation

richp405
Copy link
Collaborator

@richp405 richp405 commented Oct 4, 2022

SUMMARY

Correction to the type declaration of ccsid in the main function of zos_mount

Fixes #352: ccsid wouldn't work as coded, because the main wanted a string, while implementation needed an integer.

Main routine changed to require integer, which reconciles requirement.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

zos_mount

@richp405 richp405 requested a review from ddimatos October 4, 2022 20:59
@ddimatos ddimatos changed the base branch from dev to release-v1.4.0-beta.2 October 4, 2022 22:09
@ddimatos ddimatos changed the title Bugfix/352/zos mount parm issue Bugfix zos_mount module where ccsid should have been a string type Oct 4, 2022
@ddimatos
Update dependency finder to support non origin/dev branch
de430d2 
Signed-off-by: ddimatos <dimatos@gmail.com>
@ddimatos
git version run on container does not support git branch --show-current
99da220 
Signed-off-by: ddimatos <dimatos@gmail.com>
@ddimatos
Work around to stderr from request-pull cmd when no key registered wi…
2f9be05 
…th gh

Signed-off-by: ddimatos <dimatos@gmail.com>
@ddimatos
Update release notes and changelog
9b947f0 
Signed-off-by: ddimatos <dimatos@gmail.com>
@ddimatos ddimatos added Bug Something isn't working as designed. In Progress This issue is under review by a team member. labels Oct 5, 2022
@ddimatos
Added changelog fragment
2487b14 
Signed-off-by: ddimatos <dimatos@gmail.com>
@ddimatos
Merge branch 'bugfix/353/zos-operator-set-issue' into bugfix/352/zos-…
b2c46bd 
…mount-parm-issue
@ddimatos
updated release notes
11616f5 
Signed-off-by: ddimatos <dimatos@gmail.com>
@ddimatos
Update release note for lint issue
cc88400 
Signed-off-by: ddimatos <dimatos@gmail.com>
@ddimatos
Update release note for lint issue
175234e 
Signed-off-by: ddimatos <dimatos@gmail.com>
@ddimatos
Copy link
Collaborator

ddimatos commented Oct 5, 2022

Pipeline long suffix /job/zosAnsible/1245/console
image

@ddimatos ddimatos merged commit 6d7febe into release-v1.4.0-beta.2 Oct 5, 2022
@ddimatos ddimatos mentioned this pull request Oct 5, 2022
Closed
@ddimatos
Copy link
Collaborator

ddimatos commented Oct 5, 2022

This will need to be forward ported to dev branch, see issue #506

@ddimatos ddimatos added Resolved The issue is resolved, authors issue has been addressed and removed In Progress This issue is under review by a team member. labels Oct 5, 2022
@ddimatos ddimatos deleted the bugfix/352/zos-mount-parm-issue branch October 8, 2022 04:12
@ddimatos ddimatos mentioned this pull request Oct 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddimatos ddimatos Awaiting requested review from ddimatos

Assignees

@richp405 richp405

Labels
Bug Something isn't working as designed. Resolved The issue is resolved, authors issue has been addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug][zos_mount] Wrong type for parameter tag_ccsid of zos_mount module
2 participants
@richp405 @ddimatos