Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix [zos_mount] ccsid type is string when it should be int, update dependency finder #511

Merged
merged 4 commits into from
Oct 6, 2022

Conversation

ddimatos
Copy link
Collaborator

@ddimatos ddimatos commented Oct 5, 2022

SUMMARY

This bugffix addresses zos_mount. It fixed option tag_ccsid to correctly allow for type int.
It addresses issue #506

It also updates the dependency finder such that it can support pull request base branches that are not only origin/dev.
It addresses also issue #508

ISSUE TYPE
  • Bugfix Pull Request

richp405 and others added 3 commits October 5, 2022 16:01
@ddimatos ddimatos changed the title Bugfix/506/zos mount ccsid type Bugfix [zos_mount] ccsid type is string when it should be int, update dependency finder Oct 5, 2022
@ddimatos ddimatos requested a review from richp405 October 5, 2022 23:27
Signed-off-by: ddimatos <dimatos@gmail.com>
@ddimatos
Copy link
Collaborator Author

ddimatos commented Oct 5, 2022

Pipeline log suffix /job/zosAnsible/1253/console
image

@ddimatos ddimatos marked this pull request as ready for review October 5, 2022 23:44
@ddimatos ddimatos self-assigned this Oct 5, 2022
@ddimatos ddimatos added Bug Something isn't working as designed. In Progress This issue is under review by a team member. labels Oct 5, 2022
Copy link
Collaborator

@richp405 richp405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty straightforward.

@ddimatos ddimatos merged commit a13e86f into dev Oct 6, 2022
@ddimatos ddimatos deleted the bugfix/506/zos_mount-ccsid-type branch October 6, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working as designed. In Progress This issue is under review by a team member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants