Forward port and merge changes from the 1.4.0-beta.2 release to our latest dev branch #536
Conversation
Signed-off-by: ddimatos <dimatos@gmail.com>
…ible 2.11 Signed-off-by: ddimatos <dimatos@gmail.com>
Signed-off-by: ddimatos <dimatos@gmail.com>
Signed-off-by: ddimatos <dimatos@gmail.com>
…emoval Signed-off-by: ddimatos <dimatos@gmail.com>
…emoval Signed-off-by: ddimatos <dimatos@gmail.com>
Signed-off-by: ddimatos <dimatos@gmail.com>
Signed-off-by: ddimatos <dimatos@gmail.com>
Signed-off-by: ddimatos <dimatos@gmail.com>
Signed-off-by: ddimatos <dimatos@gmail.com>
Signed-off-by: ddimatos <dimatos@gmail.com>
Signed-off-by: ddimatos <dimatos@gmail.com>
Signed-off-by: ddimatos <dimatos@gmail.com>
Signed-off-by: ddimatos <dimatos@gmail.com>
Signed-off-by: ddimatos <dimatos@gmail.com>
Signed-off-by: ddimatos <dimatos@gmail.com>
Signed-off-by: ddimatos <dimatos@gmail.com>
Signed-off-by: ddimatos <dimatos@gmail.com>
Signed-off-by: ddimatos <dimatos@gmail.com>
Signed-off-by: ddimatos <dimatos@gmail.com>
Signed-off-by: ddimatos <dimatos@gmail.com>
Signed-off-by: ddimatos <dimatos@gmail.com>
…ogic Signed-off-by: ddimatos <dimatos@gmail.com>
…e change Signed-off-by: ddimatos <dimatos@gmail.com>
Signed-off-by: ddimatos <dimatos@gmail.com>
Signed-off-by: ddimatos <dimatos@gmail.com>
|
URL Suffix: |
ddimatos
changed the title
|
Hi @fernandofloresg , @ketankelkar , @rexemin @richp405 please go over this PR, it did pass regression, I think all you need to focus on is modules, plugins, module_utils and test cases, ignore the rest if you want its simply release content after is nearly 100 files. This forward ports zos_copy which touched module_utils , plugin and module for zos_copy, so the focus should be that we did not lose any bugs we fixed in the dev branch and ensure all new tests were ported over correctly, i did modify/add a couple. So if you did any work in the dev branch, just be sure its still there. @rexemin can I get some extra focus on if these were ported correctly, i looked last week week and think they were fine, ill do it again but just wanted extra eyes on it. |
| @@ -92,6 +92,10 @@ class DataSet(object): | |||
|
|
|||
| _VSAM_UNCATALOG_COMMAND = " DELETE '{0}' NOSCRATCH" | |||
|
|
|||
| MVS_PARTITIONED = frozenset({"PE", "PO", "PDSE", "PDS"}) | |||
| MVS_SEQ = frozenset({"PS", "SEQ", "BASIC"}) | |||
| MVS_VSAM = frozenset({"KSDS", "ESDS", "RRDS", "LDS", "VSAM"}) | |||
There was a problem hiding this comment.
Not an issue but why use a frozenset?
There was a problem hiding this comment.
Not sure what their reason was but given a frozen set is an immutable set maybe they just did not want anyone to alter them after creation.
There was a problem hiding this comment.
To avoid accidentally adding or removing elements, that could cause problems between calls of the class' methods.
There was a problem hiding this comment.
Thanks for the clarification @rexemin 👍
|
Thanks everyone, going to merge it now :) |
SUMMARY
This issues addresses:
This pull request level sets the development branch with any code that needed to be ported, ensures we have no sanity failures and aligns documentation with the next release.