Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copy lib member test case for 1.5.0 #736

Merged
merged 4 commits into from
Apr 14, 2023

Conversation

fernandofloresg
Copy link
Collaborator

SUMMARY

The fix for this issue was merged in #641, but the test case took more time to finalize.

ISSUE TYPE
  • Enhancement Pull Request
COMPONENT NAME

module_utils/zostest_zos_copy_func.py

ADDITIONAL INFORMATION

@fernandofloresg
Copy link
Collaborator Author

Also, based on comments by Demetri changed the changelog for the fix to the correct PR number in fragment.

@fernandofloresg
Copy link
Collaborator Author

Screenshot 2023-04-13 at 8 36 48 PM

Screenshot 2023-04-13 at 8 37 46 PM

@fernandofloresg fernandofloresg self-assigned this Apr 14, 2023
@ddimatos ddimatos added In Progress This issue is under review by a team member. Changes Requested labels Apr 14, 2023
Copy link
Collaborator

@richp405 richp405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good to me. I think the fragment needs 2 changes: use this PR number (736) and add newline at end.

changelogs/fragments/641-copy-loadlib-member.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@ddimatos ddimatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I am good with this, thanks for the forward port.

@richp405 richp405 merged commit 787d3df into release-v1.5.0 Apr 14, 2023
@richp405 richp405 deleted the enhancement/copy-lib-member-test-1.5.0 branch April 14, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes Requested In Progress This issue is under review by a team member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants