-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/619/v1.4.1/zos copy mode fix #742
Merged
ddimatos
merged 2 commits into
suppor/v1.4.1-releas-tasks
from
bugfix/619/v1.4.1/zos_copy_mode_fix
Apr 18, 2023
Merged
Bugfix/619/v1.4.1/zos copy mode fix #742
ddimatos
merged 2 commits into
suppor/v1.4.1-releas-tasks
from
bugfix/619/v1.4.1/zos_copy_mode_fix
Apr 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b0adee0
to
fd9a646
Compare
44bb156
to
7d3ddf5
Compare
fernandofloresg
approved these changes
Apr 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
ddimatos
approved these changes
Apr 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, and as I understand it we have existing tests cases for this so no needed test case was added. Thank you.
ddimatos
added a commit
that referenced
this pull request
Apr 19, 2023
* Correct version in meta.yml * Update copyright year in readme * Add correct year in zos_copy copyright * Add correct year in zos_operator copyright * Added correct year in zos_job_query copyright * Add changelog fragment for version * Generated changelog * Add release notes * Updated module docs based on module-doc * Bugfix/619/v1.4.1/zos copy mode fix (#742) * Add to work as comunity module * Add changelog --------- Co-authored-by: Andre Marcel Gutierrez Benitez <andre@MacBook-Pro-de-Andre-2.local> * Added contributor to galaxy.yml * Updated changelog * Updated release notes * Update readme to include which versions of Ansible are supported Signed-off-by: ddimatos <dimatos@gmail.com> * update release notes Signed-off-by: ddimatos <dimatos@gmail.com> * update runtime to include all of 2.14 Signed-off-by: ddimatos <dimatos@gmail.com> * Fix galaxy-importer issue --------- Signed-off-by: ddimatos <dimatos@gmail.com> Co-authored-by: André Marcel Gutiérrez Benítez <68956970+AndreMarcel99@users.noreply.github.com> Co-authored-by: Andre Marcel Gutierrez Benitez <andre@MacBook-Pro-de-Andre-2.local> Co-authored-by: ddimatos <dimatos@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Mode set for files is applied to destination directory by change the logic of changing files
Fixed #619
ISSUE TYPE
COMPONENT NAME
Add logic if to verify the destiny folder to copy to only change mode to files not folder.
ADDITIONAL INFORMATION
When the only and last file of the copy is a folder does not apply the change of mode with and if statement.
The PR in dev pass without test case, more than playbook results.