Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance zos_archive and zos_unarchive test cases #965

Merged
merged 7 commits into from
Sep 13, 2023

Conversation

fernandofloresg
Copy link
Collaborator

@fernandofloresg fernandofloresg commented Sep 11, 2023

SUMMARY

Enhance the zos_archive and zos_unarchive, original idea was to simplify test cases but added test_lines with the actual record length of the dataset and take into account RDW.

Fixes #897

ISSUE TYPE
  • Enhancement Pull Request

@fernandofloresg
Copy link
Collaborator Author

Screenshot 2023-09-12 at 10 30 20 AM

@fernandofloresg fernandofloresg marked this pull request as ready for review September 12, 2023 16:36
Signed-off-by: Fernando Flores <fernandofloresdev@gmail.com>
Copy link
Collaborator

@AndreMarcel99 AndreMarcel99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean change, maybe the idea is take this changes and add test cases to exceed record length, and in a full capacity to see how archive and unarchive the content.

Copy link
Collaborator

@rexemin rexemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call to use lines the size of the record length for these tests, looks good

@fernandofloresg
Copy link
Collaborator Author

Screenshot 2023-09-13 at 4 35 44 PM With latest changes

@fernandofloresg fernandofloresg merged commit 0ce455c into dev Sep 13, 2023
@fernandofloresg fernandofloresg deleted the enhancement/897-simplify-archive-tests branch September 13, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] [zos_archive, zos_unarchive] Simplify test cases
3 participants