Add helm dependency update #208

WissemChb · 2021-08-17T20:41:31Z

SUMMARY

Execute the helm dependency update under the hood when found dependencies block in Chart.yaml file.
Support the execution of:

Standalone dependency update by executing: helm dependency update CHART
Inline dependency update when specifying the helm chart_repo_url by adding --dependency-update to the helm install command.

ISSUE TYPE

Feature Pull Request Add dependency update command to Helm module #191

COMPONENT NAME

helm, helm_template

ADDITIONAL INFORMATION

There is a doc generated for history_max option for the helm module. I think that is not generated in the previous PR helm: add support for history-max parameter #164.
There is others changes affect the docs/ folder when I run the collection_prep_add_docs -p . command. These changes are added in the last commit 64eab40. I let you decide rather we keep the commit or remove it.
The --dependency-update insertion option is tested used a local helm chart repository create via docker. So here are the tasks that test this feature. Maybe if we create a GitHub repository for the helm chart, we can add this test code in the CI pipeline.

# Test The update dependency with chart_repo_url
- name: "Test chart without dependencies block and chart_repo_url defined"
  block:
    - name: "Test chart without dependencies block and chart_repo_url defined"
      helm:
        binary_path: "{{ helm_binary }}"
        name: test
        chart_ref: "ingress-nginx"
        chart_repo_url: https://kubernetes.github.io/ingress-nginx
        chart_version: "{{ chart_source_version | default(omit) }}"
        namespace: "{{ helm_namespace }}"
        create_namespace: yes
      register: release

    - assert:
        that:
          - "'--dependency-update' not in release.command"
          - "'upgrade' in release.command"
        success_msg: "Command does not contains '--dependency-update' options"
        fail_msg: "Command contains '--dependency-update' options"

- name: "Test chart with dependencies block and chart_repo_url defined and replace True"
  block:
    - name: "Test chart with dependencies block and chart_repo_url defined and replace True"
      helm:
        binary_path: "{{ helm_binary }}"
        name: test1
        chart_ref: "dep_up"
        chart_repo_url: http://repo:8080/charts
        chart_version: "{{ chart_source_version | default(omit) }}"
        namespace: "{{ helm_namespace }}"
        create_namespace: yes
        replace: true
      register: release
    - debug: var=release
    - assert:
        that:
          - "'--dependency-update' in release.command"
          - "'install' in release.command"
        success_msg: "Command contains '--dependency-update' options with helm install command"
        fail_msg: "Command not contains '--dependency-update' with helm install command"

- name: "Test chart with dependencies block and chart_repo_url defined and replace False fails"
  block:
    - name: "Test chart with dependencies block and chart_repo_url defined and replace False fails"
      helm:
        binary_path: "{{ helm_binary }}"
        name: test2
        chart_ref: "dep_up"
        chart_repo_url: http://repo:8080/charts
        chart_version: "{{ chart_source_version | default(omit) }}"
        namespace: "{{ helm_namespace }}"
        create_namespace: yes
        replace: false
      register: release
      ignore_errors: true

    - assert:
        that:
          - release.failed
          - release.msg == "'--dependency-update' hasn't been supported yet with 'helm upgrade'. Please use 'helm install' instead by adding 'replace' option"
        success_msg: "Command build fail when adding  '--dependency-update' with the helm upgrade command"

gravesm · 2021-08-19T18:55:14Z

@WissemChb thanks for the PR! This is looking like a good start. I think the better way to do this is to add a dependency_update parameter as you initially suggested in your issue, though. This PR forces the update which would change the existing behavior and also not allow any control over whether or not to do the update.

With regards to the docs changes, you should restore all the deleted .rst files. The doc generation command is pretty rough and ideally shouldn't be deleting those. The other changes you can keep. We always generate the docs right before a release but it's fine to go ahead and run it now, too.

WissemChb · 2021-08-20T09:45:47Z

@WissemChb thanks for the PR! This is looking like a good start. I think the better way to do this is to add a dependency_update parameter as you initially suggested in your issue, though. This PR forces the update which would change the existing behavior and also not allow any control over whether or not to do the update.

With regards to the docs changes, you should restore all the deleted .rst files. The doc generation command is pretty rough and ideally shouldn't be deleting those. The other changes you can keep. We always generate the docs right before a release but it's fine to go ahead and run it now, too.

Hello @gravesm, Thank you for your reply. I'll take into consideration your suggestions. Initially, I considered adding the dependency_update option but when I go through the dev process I decide to simplify the module params and options. But you are right it's better to add more control over the update process.

gravesm

Thanks for your work on this, and for adding tests! In addition to inline comments we'll need a changelog fragment: https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs

molecule/default/roles/helm/tasks/tests_chart.yml

plugins/modules/helm.py

gravesm · 2021-08-24T18:36:16Z

plugins/modules/helm.py

+                if not replace:
+                    msg_fail = ("'--dependency-update' hasn't been supported yet with 'helm upgrade'. "
+                                "Please use 'helm install' instead by adding 'replace' option")
+                    module.fail_json(msg=msg_fail)


This block can be replaced by making the dependency_update param mutually exclusive with replace. See the argument spec at the top of this method.

This part is becoming very confusing for me. for 2 reasons:

What I found in Ansible doc is that if I make dependency_update and replace mutually exclusive I can't enable both of them and that is not the case because when the chart_ref_url is defined or chart_ref is an URL I need to enable replace option when dependency_update is enabled to use helm install instead of helm update(not support --dependency-update option. I'm sorry, this is my first ansible module creation maybe I need more details about your suggestion.

After doing a deep search I realised that we haven't the need to do dependency update with remote charts because to package them we need to pull the subchart by running helm package --dependency-update dep-up So, if I'm not mistaken, all remote package that depends on other charts have their subchart pulled already within them.

plugins/modules/helm.py

molecule/default/roles/helm/tasks/install.yml

molecule/default/roles/helm/tasks/test_up_dep.yml

plugins/modules/helm.py

plugins/modules/helm_template.py

docs/kubernetes.core.k8s_json_patch_module.rst

docs/kubernetes.core.k8s_log_module.rst

docs/kubernetes.core.k8s_lookup.rst

plugins/modules/helm.py

WissemChb · 2021-10-02T19:51:11Z

@gravesm and @abikouo, I added what you suggested. Can you check, please ? Thank you very much for your the time to make the review.

one of the three sanity tests fails in the Zuul pipeline can you please check and tell me what I missed because the test worked fine in local for me.

abikouo · 2021-10-06T15:57:47Z

recheck

docs/kubernetes.core.k8s_json_patch_module.rst

docs/kubernetes.core.k8s_log_module.rst

docs/kubernetes.core.k8s_lookup.rst

docs/kubernetes.core.helm_template_module.rst

joestump · 2022-04-17T02:01:50Z

Got bit by this today. Anything I can do to help?

Co-authored-by: Mike Graves <mgraves@redhat.com>

- remove fail execution when dependencies block not found - add unit tests for helm_template

gravesm · 2022-04-18T15:11:23Z

Sorry, this one appears to have fallen through the cracks. I've gone ahead and rebased, and fixed a few things to account for recent changes to our CI.

softwarefactory-project-zuul · 2022-04-18T15:33:06Z

Build failed.

build-ansible-collection : SUCCESS in 4m 06s
ansible-test-sanity-docker-devel : SUCCESS in 10m 53s (non-voting)
ansible-test-sanity-docker-milestone : SUCCESS in 11m 58s
ansible-test-sanity-docker-stable-2.9 : SUCCESS in 13m 01s
ansible-test-sanity-docker-stable-2.11 : SUCCESS in 11m 31s
ansible-test-sanity-docker-stable-2.12 : SUCCESS in 10m 40s
ansible-test-units-kubernetes-core-python38 : SUCCESS in 6m 06s
ansible-test-splitter : SUCCESS in 5m 43s
integration-kubernetes.core-devel-1 : SUCCESS in 13m 24s (non-voting)
integration-kubernetes.core-devel-2 : SKIPPED (non-voting)
integration-kubernetes.core-devel-3 : SKIPPED (non-voting)
integration-kubernetes.core-milestone-1 : SUCCESS in 15m 28s
integration-kubernetes.core-milestone-2 : SKIPPED
integration-kubernetes.core-milestone-3 : SKIPPED
integration-kubernetes.core-2.9-1 : SUCCESS in 13m 58s
integration-kubernetes.core-2.9-2 : SKIPPED
integration-kubernetes.core-2.9-3 : SKIPPED
integration-kubernetes.core-2.10-1 : SUCCESS in 14m 05s
integration-kubernetes.core-2.10-2 : SKIPPED
integration-kubernetes.core-2.10-3 : SKIPPED
integration-kubernetes.core-with-turbo-1 : SUCCESS in 13m 25s
integration-kubernetes.core-with-turbo-2 : SKIPPED
integration-kubernetes.core-with-turbo-3 : SKIPPED
ansible-tox-linters : SUCCESS in 5m 47s
ansible-ee-tests-stable-2.12 : FAILURE in 12m 32s (non-voting)
ansible-ee-tests-latest : FAILURE in 13m 33s (non-voting)
ansible-ee-tests-stable-2.9 : FAILURE in 11m 49s
ansible-ee-tests-stable-2.11 : SUCCESS in 11m 32s
ansible-galaxy-importer : SUCCESS in 5m 22s

gravesm · 2022-04-22T12:08:14Z

recheck

softwarefactory-project-zuul · 2022-04-22T12:34:20Z

Build succeeded.

build-ansible-collection : SUCCESS in 4m 09s
ansible-test-sanity-docker-devel : SUCCESS in 12m 11s (non-voting)
ansible-test-sanity-docker-milestone : SUCCESS in 11m 46s
ansible-test-sanity-docker-stable-2.9 : SUCCESS in 13m 37s
ansible-test-sanity-docker-stable-2.11 : SUCCESS in 12m 39s
ansible-test-sanity-docker-stable-2.12 : SUCCESS in 12m 02s
ansible-test-units-kubernetes-core-python38 : SUCCESS in 9m 56s
ansible-test-splitter : SUCCESS in 4m 41s
integration-kubernetes.core-devel-1 : SUCCESS in 14m 41s (non-voting)
integration-kubernetes.core-devel-2 : SKIPPED (non-voting)
integration-kubernetes.core-devel-3 : SKIPPED (non-voting)
integration-kubernetes.core-milestone-1 : SUCCESS in 14m 42s
integration-kubernetes.core-milestone-2 : SKIPPED
integration-kubernetes.core-milestone-3 : SKIPPED
integration-kubernetes.core-2.9-1 : SUCCESS in 15m 28s
integration-kubernetes.core-2.9-2 : SKIPPED
integration-kubernetes.core-2.9-3 : SKIPPED
integration-kubernetes.core-2.10-1 : SUCCESS in 15m 53s
integration-kubernetes.core-2.10-2 : SKIPPED
integration-kubernetes.core-2.10-3 : SKIPPED
integration-kubernetes.core-with-turbo-1 : SUCCESS in 16m 30s
integration-kubernetes.core-with-turbo-2 : SKIPPED
integration-kubernetes.core-with-turbo-3 : SKIPPED
ansible-tox-linters : SUCCESS in 6m 05s
ansible-ee-tests-stable-2.12 : FAILURE in 12m 48s (non-voting)
ansible-ee-tests-latest : FAILURE in 12m 58s (non-voting)
ansible-ee-tests-stable-2.9 : SUCCESS in 13m 08s (non-voting)
ansible-ee-tests-stable-2.11 : SUCCESS in 13m 48s
ansible-galaxy-importer : SUCCESS in 6m 08s

abikouo

LGTM!!

softwarefactory-project-zuul · 2022-04-25T07:23:28Z

Build succeeded.

build-ansible-collection : SUCCESS in 4m 41s
ansible-test-sanity-docker-devel : SUCCESS in 13m 48s (non-voting)
ansible-test-sanity-docker-milestone : SUCCESS in 12m 13s
ansible-test-sanity-docker-stable-2.9 : SUCCESS in 14m 57s
ansible-test-sanity-docker-stable-2.11 : SUCCESS in 12m 47s
ansible-test-sanity-docker-stable-2.12 : SUCCESS in 12m 21s
ansible-test-units-kubernetes-core-python38 : SUCCESS in 8m 28s
ansible-test-splitter : SUCCESS in 5m 11s
integration-kubernetes.core-devel-1 : SUCCESS in 14m 00s (non-voting)
integration-kubernetes.core-devel-2 : SKIPPED (non-voting)
integration-kubernetes.core-devel-3 : SKIPPED (non-voting)
integration-kubernetes.core-milestone-1 : SUCCESS in 14m 24s
integration-kubernetes.core-milestone-2 : SKIPPED
integration-kubernetes.core-milestone-3 : SKIPPED
integration-kubernetes.core-2.9-1 : SUCCESS in 14m 53s
integration-kubernetes.core-2.9-2 : SKIPPED
integration-kubernetes.core-2.9-3 : SKIPPED
integration-kubernetes.core-2.10-1 : SUCCESS in 14m 04s
integration-kubernetes.core-2.10-2 : SKIPPED
integration-kubernetes.core-2.10-3 : SKIPPED
integration-kubernetes.core-with-turbo-1 : SUCCESS in 14m 06s
integration-kubernetes.core-with-turbo-2 : SKIPPED
integration-kubernetes.core-with-turbo-3 : SKIPPED
ansible-tox-linters : SUCCESS in 6m 48s
ansible-ee-tests-stable-2.12 : FAILURE in 12m 33s (non-voting)
ansible-ee-tests-latest : FAILURE in 12m 16s (non-voting)
ansible-ee-tests-stable-2.9 : SUCCESS in 14m 50s (non-voting)
ansible-ee-tests-stable-2.11 : SUCCESS in 11m 37s
ansible-galaxy-importer : SUCCESS in 6m 44s

softwarefactory-project-zuul · 2022-04-26T11:54:36Z

Build succeeded (gate pipeline).

build-ansible-collection : SUCCESS in 4m 23s
ansible-test-sanity-docker-devel : SUCCESS in 11m 38s (non-voting)
ansible-test-sanity-docker-milestone : SUCCESS in 10m 46s
ansible-test-sanity-docker-stable-2.9 : SUCCESS in 13m 13s
ansible-test-sanity-docker-stable-2.11 : SUCCESS in 11m 21s
ansible-test-sanity-docker-stable-2.12 : SUCCESS in 12m 42s
ansible-test-units-kubernetes-core-python38 : SUCCESS in 7m 13s
ansible-test-splitter : SUCCESS in 5m 16s
integration-kubernetes.core-devel-1 : SUCCESS in 18m 43s (non-voting)
integration-kubernetes.core-devel-2 : SKIPPED (non-voting)
integration-kubernetes.core-devel-3 : SKIPPED (non-voting)
integration-kubernetes.core-milestone-1 : SUCCESS in 14m 23s
integration-kubernetes.core-milestone-2 : SKIPPED
integration-kubernetes.core-milestone-3 : SKIPPED
integration-kubernetes.core-2.9-1 : SUCCESS in 14m 56s
integration-kubernetes.core-2.9-2 : SKIPPED
integration-kubernetes.core-2.9-3 : SKIPPED
integration-kubernetes.core-2.10-1 : SUCCESS in 18m 03s
integration-kubernetes.core-2.10-2 : SKIPPED
integration-kubernetes.core-2.10-3 : SKIPPED
integration-kubernetes.core-with-turbo-1 : SUCCESS in 14m 48s
integration-kubernetes.core-with-turbo-2 : SKIPPED
integration-kubernetes.core-with-turbo-3 : SKIPPED
ansible-tox-linters : SUCCESS in 6m 45s
ansible-ee-tests-stable-2.12 : FAILURE in 11m 52s (non-voting)
ansible-ee-tests-latest : FAILURE in 12m 39s (non-voting)
ansible-ee-tests-stable-2.9 : SUCCESS in 14m 03s (non-voting)
ansible-ee-tests-stable-2.11 : SUCCESS in 11m 11s
ansible-galaxy-importer : SUCCESS in 5m 07s

7.3.0 Major Changes ------------- kubernetes.core ~~~~~~~~~~~~~~~ - refactor K8sAnsibleMixin into module_utils/k8s/ (ansible-collections/kubernetes.core#481). Minor Changes ------------- Ansible-core ~~~~~~~~~~~~ - Make using blocks as handlers a parser error (ansible/ansible#79968) - ansible-test - Specify the configuration file location required by test plugins when the config file is not found. This resolves issue: ansible/ansible#79411 - ansible-test - Update error handling code to use Python 3.x constructs, avoiding direct use of ``errno``. - ansible-test acme test container - update version to update used Pebble version, underlying Python and Go base containers, and Python requirements (ansible/ansible#79783). cisco.aci ~~~~~~~~~ - Add Node Profile BGP Peer and Route Control Profile functionalities to aci_l3out_bgp_peer module - Add SVI auto state support (auto_state attribute) to aci_l3out_interface - Add aci_aaa_domain, aci_aaa_role and aci_custom_privilege modules - Add aci_fabric_pod_policy_group module - Add aci_interface_policy_leaf_profile_fex_policy_group module and add FEX support to aci_access_port_to_interface_policy_leaf_profile - Add aci_tenant_span_src_group_src module - Add action_groups for module_defaults - Add support for filter direction in aci_contract_subject and aci_contract_subject_to_filter - Update modules to assign roles and permissions to a user cisco.nxos ~~~~~~~~~~ - `nxos_acls` - Support ICMPv6 option. Please refer to module doc for all new options (ansible-collections/cisco.nxos#624). - `nxos_facts` - Update facts gathering logic to ensure that `gather_network_resources: all` does not fail for NX-OS on MDS switches. - `nxos_l2_interfaces` - Add new mode dot1q-tunnel (ansible-collections/cisco.nxos#600). community.crypto ~~~~~~~~~~~~~~~~ - get_certificate - adds ``ciphers`` option for custom cipher selection (ansible-collections/community.crypto#571). community.general ~~~~~~~~~~~~~~~~~ - dnsimple - set custom User-Agent for API requests to DNSimple (ansible-collections/community.general#5927). - flatpak_remote - add new boolean option ``enabled``. It controls, whether the remote is enabled or not (ansible-collections/community.general#5926). - gitlab_project - add ``releases_access_level``, ``environments_access_level``, ``feature_flags_access_level``, ``infrastructure_access_level``, ``monitor_access_level``, and ``security_and_compliance_access_level`` options (ansible-collections/community.general#5986). - jc filter plugin - added the ability to use parser plugins (ansible-collections/community.general#6043). - keycloak_group - add new optional module parameter ``parents`` to properly handle keycloak subgroups (ansible-collections/community.general#5814). - keycloak_user_federation - make ``org.keycloak.storage.ldap.mappers.LDAPStorageMapper`` the default value for mappers ``providerType`` (ansible-collections/community.general#5863). - ldap modules - add ``xorder_discovery`` option (ansible-collections/community.general#6045, ansible-collections/community.general#6109). - lxd_container - add diff and check mode (ansible-collections/community.general#5866). - mattermost, rocketchat, slack - replace missing default favicon with docs.ansible.com favicon (ansible-collections/community.general#5928). - modprobe - add ``persistent`` option (ansible-collections/community.general#4028, ansible-collections/community.general#542). - osx_defaults - include stderr in error messages (ansible-collections/community.general#6011). - proxmox - suppress urllib3 ``InsecureRequestWarnings`` when ``validate_certs`` option is ``false`` (ansible-collections/community.general#5931). - redfish_command - adding ``EnableSecureBoot`` functionality (ansible-collections/community.general#5899). - redfish_command - adding ``VerifyBiosAttributes`` functionality (ansible-collections/community.general#5900). - sefcontext - add support for path substitutions (ansible-collections/community.general#1193). community.grafana ~~~~~~~~~~~~~~~~~ - able to set `uid` for datasources in grafana via module grafana_datasource community.mongodb ~~~~~~~~~~~~~~~~~ - 491 mongodb_shell - Add feature to detect if mongo or mongosh is available. - 494 mongodb_auth - Removes module_defaults from role. - 494 mongodb_shutdown - Fix examples block. - 511 mongodb_auth - Adds support for deletion of users. - 514 mongodb_linux - Remove extended FQCN for pam_limits. - 524 mongodb_auth - Add supports for Amazon Linux 2. - 528 multiple roles - Use first ip address when multiple bind IPs provided. - 530 mongodb_role - Adds new module to manage MongoDB roles. - 536 mongodb_auth - Add user after enabling authentication. - 544 mongodb_replicaset - Module documentation improvements. - 547 mongodb_repository - Bump default of MongoDB to 6.0. community.mysql ~~~~~~~~~~~~~~~ - mysql_info - add ``connector_name`` and ``connector_version`` to returned values (ansible-collections/community.mysql#497). - mysql_role - enable auto_commit to avoid MySQL metadata table lock (ansible-collections/community.mysql#479). - mysql_user - add plugin_auth_string as optional parameter to use a specific pam service if pam/auth_pam plugin is used (ansible-collections/community.mysql#445). - mysql_user - add the ``session_vars`` argument to set session variables at the beginning of module execution (ansible-collections/community.mysql#478). - mysql_user - display a more informative invalid privilege exception. Changes the exception handling of the granting permission logic to show the query executed , params and the exception message granting privileges fails` (ansible-collections/community.mysql#465). - mysql_user - enable auto_commit to avoid MySQL metadata table lock (ansible-collections/community.mysql#479). - setup_mysql - update MySQL tarball URL (ansible-collections/community.mysql#491). community.vmware ~~~~~~~~~~~~~~~~ - vmware_guest_disk - Add support for IDE disk add, remove or reconfigure, and change to gather same VM disk info as in vmware_guest_disk_info (ansible-collections/community.vmware#1428). - vmware_guest_disk - Extend return value documentation for vmware_guest_disk (ansible-collections/community.vmware#1641) - vmware_guest_disk_info - Move gather VM disk info function to vm_device_helper.py (ansible-collections/community.vmware#1617) - vmware_vmotion - New parameter timeout in order to allow vmotions running longer than 1 hour (https://github.com/ansible-collections/community.vmware/pulls/1629). grafana.grafana ~~~~~~~~~~~~~~~ - Updated the return message in grafana.grafana.folder module hetzner.hcloud ~~~~~~~~~~~~~~ - hcloud_server - add private_networks_info containing name and private ip in responses - hcloud_server_info - add private_networks_info containing name and private ip in responses - inventory plugin - Add list of all private networks to server variables. - inventory plugin - Add new connect_with setting public_ipv6 to connect to discovered servers via public IPv6 address. - inventory plugin - Add public IPv6 address to server variables. - inventory plugin - Log warning instead of crashing when some servers do not work with global connect_with setting. inspur.ispim ~~~~~~~~~~~~ - Change the ansible-test.yml application file version. - Change the description of the edit_bios module file_url field. - Modify the description information of the backup module item field. - Modify the description of the media_attach, retry_count, and retry_time_interval fields of the edit_kvm module. - Modify the description of the secure_channel field of the edit_media_instance module. - Modify the description of the slot and vname fields of the add_ldisk module. - Modify the edit_ntp module example. - Modify the edit_snmp_trap module version field description information. - Modify the mode field description information of update_fw module. - Modify the name field description of the user_group module. - Modify the restore module example. - Modify the supporting properties and description information of the edit_ncsi module edit_ncsi field. - The edit_power_budget module adds the except_action field. kubernetes.core ~~~~~~~~~~~~~~~ - Adjust k8s_user_impersonation tests to be compatible with Kubernetes 1.24 (ansible-collections/kubernetes.core#520). - add support for dry run with kubernetes client version >=18.20 (ansible-collections/kubernetes.core#245). - added ignore.txt for Ansible 2.14 devel branch. - fixed module_defaults by removing routing hacks from runtime.yml (ansible-collections/kubernetes.core#347). - helm - add support for -set-file, -set-json, -set and -set-string options when running helm install (ansible-collections/kubernetes.core#533). - helm - add support for helm dependency update (ansible-collections/kubernetes.core#208). - helm - add support for post-renderer flag (ansible-collections/kubernetes.core#30). - helm - add support for timeout cli parameter to allow setting Helm timeout independent of wait (ansible-collections/kubernetes.core#67). - helm - add support for wait parameter for helm uninstall command. (https://github.com/ansible-collections/kubernetes/core/issues/33). - helm - support repo location for helm diff (ansible-collections/kubernetes.core#174). - helm - when ansible is executed in check mode, return the diff between what's deployed and what will be deployed. - helm, helm_plugin, helm_info, helm_plugin_info, kubectl - add support for in-memory kubeconfig. (ansible-collections/kubernetes.core#492). - helm_info - add hooks, notes and manifest as part of returned information (ansible-collections/kubernetes.core#546). - helm_info - add release state as a module argument (ansible-collections/kubernetes.core#377). - helm_info - added possibility to get all values by adding get_all_values parameter (ansible-collections/kubernetes.core#531). - helm_plugin - Add plugin_version parameter to the helm_plugin module (ansible-collections/kubernetes.core#157). - helm_plugin - Add support for helm plugin update using state=update. - helm_repository - Ability to replace (overwrite) the repo if it already exists by forcing (ansible-collections/kubernetes.core#491). - helm_repository - add support for pass-credentials cli parameter (ansible-collections/kubernetes.core#282). - helm_repository - added support for ``host``, ``api_key``, ``validate_certs``, and ``ca_cert``. - helm_repository - mark `pass_credentials` as no_log=True to silence false warning (ansible-collections/kubernetes.core#412). - helm_template - add name (NAME of release) and disable_hook as optional module arguments (ansible-collections/kubernetes.core#313). - helm_template - add show_only and release_namespace as module arguments (ansible-collections/kubernetes.core#313). - helm_template - add support for -set-file, -set-json, -set and -set-string options when running helm template (ansible-collections/kubernetes.core#546). - k8s - add no_proxy support to k8s* (ansible-collections/kubernetes.core#272). - k8s - add support for server_side_apply. (ansible-collections/kubernetes.core#87). - k8s - add support for user impersonation. (https://github.com/ansible-collections/kubernetes/core/issues/40). - k8s - allow resource definition using metadata.generateName (ansible-collections/kubernetes.core#35). - k8s lookup plugin - Enable turbo mode via environment variable (ansible-collections/kubernetes.core#291). - k8s, k8s_scale, k8s_service - add support for resource definition as manifest via. (ansible-collections/kubernetes.core#451). - k8s_cp - remove dependency with 'find' executable on remote pod when state=from_pod (ansible-collections/kubernetes.core#486). - k8s_drain - Adds ``delete_emptydir_data`` option to ``k8s_drain.delete_options`` to evict pods with an ``emptyDir`` volume attached (ansible-collections/kubernetes.core#322). - k8s_exec - select first container from the pod if none specified (ansible-collections/kubernetes.core#358). - k8s_exec - update deprecation warning for `return_code` (ansible-collections/kubernetes.core#417). - k8s_json_patch - minor typo fix in the example section (ansible-collections/kubernetes.core#411). - k8s_log - add the ``all_containers`` for retrieving all containers' logs in the pod(s). - k8s_log - added the `previous` parameter for retrieving the previously terminated pod logs (ansible-collections/kubernetes.core#437). - k8s_log - added the `tail_lines` parameter to limit the number of lines to be retrieved from the end of the logs (ansible-collections/kubernetes.core#488). - k8s_rollback - add support for check_mode. (https://github.com/ansible-collections/kubernetes/core/issues/243). - k8s_scale - add support for check_mode. (https://github.com/ansible-collections/kubernetes/core/issues/244). - kubectl - wait for dd command to complete before proceeding (ansible-collections/kubernetes.core#321). - kubectl.py - replace distutils.spawn.find_executable with shutil.which in the kubectl connection plugin (ansible-collections/kubernetes.core#456). netapp.ontap ~~~~~~~~~~~~ - na_ontap_aggregate - new option ``allow_flexgroups`` added. - na_ontap_cifs - new options ``access_based_enumeration``, ``change_notify``, ``encryption``, ``home_directory``, ``oplocks``, ``show_snapshot``, ``allow_unencrypted_access``, ``namespace_caching`` and ``continuously_available`` added in REST. - na_ontap_dns - ``skip_validation`` option requires 9.9.1 or later with REST and ignored for cluster DNS operations. - na_ontap_dns - support cluster scope for modify and delete. - na_ontap_interface - do not attempt to migrate FC interface if desired ``home_port``, ``home_node`` and ``current_port``, ``current_node`` are same. - na_ontap_license - support for NLF v2 license files. - na_ontap_nfs - new options ``root``, ``windows`` and ``security`` added in REST. - na_ontap_user_role - ``command_directory_name`` is required if ``privileges`` not set in REST. - na_ontap_user_role - ``path`` is required if ``privileges`` set in REST. - na_ontap_volume_efficiency - REST support for ``policy`` requires 9.7 or later, ``path`` requires 9.9.1 or later and ``volume_efficiency`` and ``start_ve_scan_old_data`` requires 9.11.1 or later. - na_ontap_volume_efficiency - ``schedule``, ``start_ve_scan_all``, ``start_ve_build_metadata``, ``start_ve_delete_checkpoint``, ``start_ve_queue_operation``, ``start_ve_qos_policy`` and ``stop_ve_all_operations`` options are not supported with REST. - na_ontap_volume_efficiency - new option ``volume_name`` added. - na_ontap_volume_efficiency - updated private cli with REST API. netbox.netbox ~~~~~~~~~~~~~ - nb_inventory - Add serial and asset tag to extracted attributes purestorage.flasharray ~~~~~~~~~~~~~~~~~~~~~~ - purefa_network - Added support for NVMe-RoCE and NVMe-TCP service types - purefa_user - Added Ops Admin role to choices - purefa_vlan - Added support for NVMe-TCP service type Breaking Changes / Porting Guide -------------------------------- hetzner.hcloud ~~~~~~~~~~~~~~ - inventory plugin - Python v3.5+ is now required. Deprecated Features ------------------- - Since the google.cloud collection seems to be maintained again, we `cancelled the removal process <https://github.com/ansible-collections/overview/blob/main/removal_from_ansible.rst#cancelling-removal-of-an-unmaintained-collection>`__. So contrary to an earlier announcement, this collection is NOT deprecated and will NOT be removed from Ansible 8 (ansible-community/community-topics#105). community.general ~~~~~~~~~~~~~~~~~ - gitlab_runner - the option ``access_level`` will lose its default value in community.general 8.0.0. From that version on, you have set this option to ``ref_protected`` explicitly, if you want to have a protected runner (ansible-collections/community.general#5925).

WissemChb force-pushed the feature/#191_Add_dependency_update_command_to_Helm_module branch from eaa140f to d906eaa Compare August 18, 2021 07:25

WissemChb marked this pull request as ready for review August 18, 2021 19:32

gravesm linked an issue Aug 19, 2021 that may be closed by this pull request

Add dependency update command to Helm module #191

Closed

WissemChb force-pushed the feature/#191_Add_dependency_update_command_to_Helm_module branch 2 times, most recently from faf5722 to 7f2f774 Compare August 21, 2021 15:27

gravesm requested changes Aug 24, 2021

View reviewed changes

WissemChb requested a review from gravesm September 4, 2021 17:19

WissemChb force-pushed the feature/#191_Add_dependency_update_command_to_Helm_module branch from 9c40159 to 5abde0d Compare September 4, 2021 17:26