generated from ansible-collections/collection_template
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use post_renderer when checking 'changed' status for a helm release #588
Merged
softwarefactory-project-zuul
merged 1 commit into
ansible-collections:main
from
pauvos:helmdiff-post-renderer
Apr 5, 2023
Merged
use post_renderer when checking 'changed' status for a helm release #588
softwarefactory-project-zuul
merged 1 commit into
ansible-collections:main
from
pauvos:helmdiff-post-renderer
Apr 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`helmdiff_check` needs to use --post-renderer if configured in order to detect changes correctly
pauvos
force-pushed
the
helmdiff-post-renderer
branch
from
February 20, 2023 11:12
b14c0a1
to
a2ec37d
Compare
recheck |
gravesm
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
helmdiff_check
needs to use --post-renderer if configured in order to detect changes correctlyidempotency still seems to work
ISSUE TYPE
COMPONENT NAME
kubernetes.core.helm
ADDITIONAL INFORMATION