Extend hidden_fields to allow more complicated field definitions #643
Conversation
|
Note that I haven't added a changelog fragment as we haven't done a release since the PR introducing this feature and the previous fragment is still valid for this change: |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 51s |
willthames
force-pushed
the
hide-fields
branch
2 times, most recently
from
0a9b5c7
to
57092c9
Compare
This allows us to ignore e.g. the last-applied-configuration annotation by specifying `metadata.annotations[kubectl.kubernetes.io/last-applied-configuration]`
willthames
force-pushed
the
hide-fields
branch
from
57092c9
to
80d9316
Compare
|
Note that it's currently impossible to meet both black and pep8 with regard to list slices black wants pep8 wants More things seem to complain about pep8. |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 40s |
|
I don't really understand why all the integration tests are failing, it doesn't seem that it's related to this PR (but happy to fix if I'm wrong about that) |
|
The failing sanity tests on milestone and devel also seem unrelated to this PR (suspect a breaking change in devel ansible which probably needs separate investigation - has the yamllint sanity check changed?) |
Needed to cope with multiple levels of bracketed keys e.g. spec.template.spec[securityContext][runAsUser] and implementing that lead to a much simpler version that finds the first key and the rest, and deals with just those two. Added more tests to cover some of the new supported cases.
willthames
force-pushed
the
hide-fields
branch
from
22f928e
to
4f60378
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 13s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 15s |
Ensure test correctly captures that hidden fields should be hidden in diffs too
willthames
force-pushed
the
hide-fields
branch
from
d14b9ca
to
99cfa89
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 29s |
SUMMARY
This allows us to ignore e.g. the last-applied-configuration annotation by specifying
metadata.annotations[kubectl.kubernetes.io/last-applied-configuration]ISSUE TYPE
COMPONENT NAME
hidden_fields