helm_pull: Silence false no_log warning

[colshine1]

SUMMARY

Apply no_log=True to pass_credentials to silence false positive warning.

Fixes similar issue to: #423

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

changelog/fragements/796-false-positive-helmull.yaml
plugins/modules/helm_pull.py

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/db57b03c41344b68b76444b42d1a5074

✔️ ansible-galaxy-importer SUCCESS in 10m 16s
✔️ build-ansible-collection SUCCESS in 5m 21s

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/1240361b377c45008e4a11669676f71b

✔️ ansible-galaxy-importer SUCCESS in 3m 59s
✔️ build-ansible-collection SUCCESS in 5m 47s

[yurnov]

confirmed that even in module_utils we have no_logs=True and password not appear in module output, it's a false positive warning

[yurnov]

Hi @colshine1,

please update the integration test with the following:
https://github.com/ansible-collections/kubernetes.core/blob/cd686316e9b3af6df67c19027b573b27468234e3/tests/integration/targets/helm_pull/tasks/main.yml#L170C1-L182C61

please add

              - '"Module did not set no_log for pass_credentials" not in _result.warnings'

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/74943cfd44674e82a16c0507efbc91df

✔️ ansible-galaxy-importer SUCCESS in 4m 33s
✔️ build-ansible-collection SUCCESS in 5m 19s

[yurnov]

LGTM

[gravesm]

Suggested change

	pass_credentials=dict(type="bool", default=False, no_log=True),
	pass_credentials=dict(type="bool", default=False, no_log=False),

This should be False since this is a false positive.