migrate cluster dpm module from community.vmware #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikemorency
requested review from
shellymiron,
elsapassaro,
anna-savina,
bardielle and
machacekondra
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
==========================================
+ Coverage 26.09% 26.74% +0.65%
==========================================
Files 19 21 +2
Lines 1667 1802 +135
Branches 331 346 +15
==========================================
+ Hits 435 482 +47
- Misses 1232 1320 +88
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bardielle
approved these changes
Oct 1, 2024
prabinovRedhat
approved these changes
Oct 1, 2024
mikemorency
force-pushed
the
mm-feature/migrate-cluster-dpm
branch
from
a96fc82 to
dbeff87
Compare
This was referenced Oct 18, 2024
softwarefactory-project-zuul bot
pushed a commit
to ansible-collections/community.vmware
that referenced
this pull request
Oct 24, 2024
SUMMARY Deprecate community.vmware.vmware_cluster_dpm in favor of vmware.vmware.cluster_dpm. ISSUE TYPE Feature Pull Request COMPONENT NAME vmware_cluster_dpm ADDITIONAL INFORMATION ansible-collections/vmware.vmware#71
softwarefactory-project-zuul bot
pushed a commit
to ansible-collections/community.vmware
that referenced
this pull request
Oct 25, 2024
Backport of #2217 SUMMARY Deprecate community.vmware.vmware_cluster_dpm in favor of vmware.vmware.cluster_dpm. ISSUE TYPE Feature Pull Request COMPONENT NAME vmware_cluster_dpm ADDITIONAL INFORMATION ansible-collections/vmware.vmware#71
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This is migrating the community.vmware.vmware_cluster_dpm module here.
The inputs have changed in name, but not functionality. I updated the names based on VMwares documentation for DPM. The old names were based on the actual cluster configuration keys, but didnt make much sense when you read the documentation or looked in the UI
The old module had no outputs. The new module outputs details about the cluster reconfiguration task if changes were made.
ISSUE TYPE
COMPONENT NAME
cluster_dpm