-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix dpm automation level option #75
fix dpm automation level option #75
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
==========================================
+ Coverage 26.09% 27.26% +1.16%
==========================================
Files 19 22 +3
Lines 1667 1867 +200
Branches 331 357 +26
==========================================
+ Hits 435 509 +74
- Misses 1232 1358 +126
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the module hasn't been released yet, right? In this case, I think it's OK.
Otherwise, I should say it's a breaking change which requires a new major version. But if the module really hasn't been released yet, we can't break any existing playbooks :-)
yea, i just merged this module a few days ago so it hasnt been released yet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SUMMARY
The automation level option for dpm_cluster did not match the options that are used in the UI. This is because the API uses a different word (automated vs automatic).
This change modifies the module options to match what the user sees in the vcenter UI and docs.
ISSUE TYPE
COMPONENT NAME
cluster_dpm