Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back the Python information #170

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Add back the Python information #170

merged 1 commit into from
Oct 26, 2022

Conversation

felixfontein
Copy link
Contributor

This will fail until ansible-community/antsibull-build#452 has been merged.

@felixfontein
Copy link
Contributor Author

The last commit shows that ansible-community/antsibull-build#452 works.

@felixfontein felixfontein mentioned this pull request Oct 13, 2022
Merged
@felixfontein felixfontein changed the title [WIP] Add back the Python information Add back the Python information Oct 13, 2022
@felixfontein
Copy link
Contributor Author

antsibull 0.51.1 has been released, which fixes the bug.

gotmax23
gotmax23 approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@gotmax23 gotmax23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be better if it was squashed so there's not useless entries in the commit message when Github squashes it, but besides that, it okay.

@felixfontein
Copy link
Contributor Author

I rebased to cut off the last two commits.

@felixfontein felixfontein merged commit 77a9192 into ansible-community:main Oct 26, 2022
@felixfontein felixfontein deleted the python branch October 26, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gotmax23 gotmax23 gotmax23 approved these changes

@rooftopcellist rooftopcellist Awaiting requested review from rooftopcellist

@Ompragash Ompragash Awaiting requested review from Ompragash

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felixfontein @gotmax23