Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add release blocker WF #194

Merged
merged 4 commits into from
Jan 18, 2023
Merged

Add release blocker WF #194

merged 4 commits into from
Jan 18, 2023

Conversation

Andersson007
Copy link
Contributor

Add release blocker WF

Relates to ansible-community/community-topics#178

Note: I intentionally don't use the term bug used in Fedora project FAQ not to narrow the definition as it can be a core feature missed somehow or whatever.

@Andersson007
Copy link
Contributor Author

ready for review

@Andersson007 Andersson007 mentioned this pull request Jan 12, 2023
Closed
@mariolenz
Copy link
Collaborator

recheck

mariolenz
mariolenz reviewed Jan 16, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@Andersson007 @mariolenz
Update README.md
29187ce 
Co-authored-by: Mario Lenz <m@riolenz.de>
mariolenz
mariolenz approved these changes Jan 17, 2023
View reviewed changes
Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mariolenz
mariolenz reviewed Jan 17, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@Andersson007 @mariolenz
Update README.md
411c2c1 
Co-authored-by: Mario Lenz <m@riolenz.de>
Andersson007
Andersson007 commented Jan 18, 2023
View reviewed changes
Copy link
Contributor Author

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added might explicitly

README.md Outdated Show resolved Hide resolved
@maxamillion
Copy link

LGTM

@felixfontein felixfontein mentioned this pull request Jan 18, 2023
Closed
felixfontein
felixfontein approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided at today's community meeting to merge this without a vote, since we agree that this is a acceptable first step. If someone wants to improve the definition of blockers, they are free to create a new PR with a more concrete/specific proposal :)

@felixfontein felixfontein merged commit 7c82cdd into ansible-community:main Jan 18, 2023
@felixfontein
Copy link
Contributor

@anweshadas thanks for getting the discussion started!
@Andersson007 thanks for creating and updating this proposal!
@mariolenz @maxamillion @samccann and everyone else involved in the discussion, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariolenz mariolenz mariolenz approved these changes

@samccann samccann samccann approved these changes

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Andersson007 @mariolenz @maxamillion @felixfontein @samccann