-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial release-process.md #227
Add initial release-process.md #227
Conversation
@anweshadas (and anyone else who has done the releases in the past that feels like chiming in) , I'd really appreciate your opinion here 😄. Am I missing anything important? Is there anything that you do differently? Is there anything that's incorrect? Also I'd appreciate more information about the release announcements (step |
ce910af
to
276c714
Compare
I am working on this. Will be sharing this by this week. |
> | ||
> Throughout this page, placeholder values in code blocks are formatted as | ||
> `{PLACEHOLDER}` where `PLACEHOLDER` describes the value to fill in. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a build check list, that might be helpful.
-
Create an issue at ansible-build-data Github repo
-
Communicate with the Community about the start and the progress
-
Build the release artifacts and package
-
PR to ansible-build-data
-
PR to ansible/ansible (PR_Porting guide)
-
Upload it to PyPI
-
Release Announcement
-
Git Tag
-
Close the Github issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Release Announcement
Can you shed some more light on this step? Where do the announcement templates come from? What Matrix rooms and mailing lists are the announcements sent to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We created a template for the announcement templates. We need to figure out a place to publish it. @gotmax23 can you suggest something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would put the template(s) in this repository as well (maybe some subdirectory of docs/
, like docs/templates/
?). That way it's also easier for folks to suggest improvements to the templates (by creating a PR).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @felixfontein that this repo is a good place to publish the announcement templates. I think a docs/announcements
or maybe just a separate folder at the repo root would work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @felixfontein that this repo is a good place to publish the announcement templates. I think a
docs/announcements
or maybe just a separate folder at the repo root would work.
I will do a separate PR on this then.
Thanks for the review @anweshadas! I left some follow up comments. |
Triggering CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ansible docsite is now part of ansible/ansible-documentation.
b4ab9f5
to
611adf9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from those few small changes everything looks good.
> | ||
> Throughout this page, placeholder values in code blocks are formatted as | ||
> `{PLACEHOLDER}` where `PLACEHOLDER` describes the value to fill in. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @felixfontein that this repo is a good place to publish the announcement templates. I think a
docs/announcements
or maybe just a separate folder at the repo root would work.
I will do a separate PR on this then.
Created the PR #258 for the announcement templates. |
611adf9
to
510b2a3
Compare
The issue brought up about pip
have been fixed.
CI is failing with:
which is not related to this PR. I'll merge this and then follow the new directions about how to handle these errors :). Thanks everyone for your feedback! |
Relates: #221