Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial release-process.md #227

Merged
merged 3 commits into from
Jul 13, 2023

Conversation

gotmax23
Copy link
Contributor

@gotmax23 gotmax23 commented May 6, 2023

Relates: #221

@gotmax23
Copy link
Contributor Author

gotmax23 commented May 6, 2023

@anweshadas (and anyone else who has done the releases in the past that feels like chiming in) , I'd really appreciate your opinion here 😄. Am I missing anything important? Is there anything that you do differently? Is there anything that's incorrect?

Also I'd appreciate more information about the release announcements (step #8). I'm not sure where the the Matrix template comes from.

@gotmax23 gotmax23 force-pushed the docs-release-process branch from ce910af to 276c714 Compare May 7, 2023 04:56
@felixfontein
Copy link
Contributor

CC @rooftopcellist

@anweshadas
Copy link
Collaborator

I am working on this. Will be sharing this by this week.

docs/release-process.md Show resolved Hide resolved
docs/release-process.md Show resolved Hide resolved
docs/release-process.md Show resolved Hide resolved
>
> Throughout this page, placeholder values in code blocks are formatted as
> `{PLACEHOLDER}` where `PLACEHOLDER` describes the value to fill in.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a build check list, that might be helpful.

  • Create an issue at ansible-build-data Github repo

  • Communicate with the Community about the start and the progress

  • Fork ansible-community/ansible-build-data

  • Build the release artifacts and package

  • PR to ansible-build-data

  • PR to ansible/ansible (PR_Porting guide)

  • Upload it to PyPI

  • Release Announcement

  • Git Tag

  • Close the Github issue

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Release Announcement

Can you shed some more light on this step? Where do the announcement templates come from? What Matrix rooms and mailing lists are the announcements sent to?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We created a template for the announcement templates. We need to figure out a place to publish it. @gotmax23 can you suggest something?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put the template(s) in this repository as well (maybe some subdirectory of docs/, like docs/templates/?). That way it's also easier for folks to suggest improvements to the templates (by creating a PR).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @felixfontein that this repo is a good place to publish the announcement templates. I think a docs/announcements or maybe just a separate folder at the repo root would work.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @felixfontein that this repo is a good place to publish the announcement templates. I think a docs/announcements or maybe just a separate folder at the repo root would work.

I will do a separate PR on this then.

@gotmax23
Copy link
Contributor Author

Thanks for the review @anweshadas! I left some follow up comments.

@gotmax23
Copy link
Contributor Author

Triggering CI

@gotmax23 gotmax23 closed this May 24, 2023
@gotmax23 gotmax23 reopened this May 24, 2023
@gotmax23 gotmax23 changed the title docs: add initial release-process.md Add initial release-process.md Jun 5, 2023
@gotmax23 gotmax23 marked this pull request as ready for review June 5, 2023 17:13
@gotmax23 gotmax23 requested a review from anweshadas June 5, 2023 17:14
Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ansible docsite is now part of ansible/ansible-documentation.

docs/release-process.md Outdated Show resolved Hide resolved
docs/release-process.md Outdated Show resolved Hide resolved
docs/release-process.md Outdated Show resolved Hide resolved
@gotmax23 gotmax23 force-pushed the docs-release-process branch 2 times, most recently from b4ab9f5 to 611adf9 Compare June 28, 2023 17:42
Copy link
Collaborator

@anweshadas anweshadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from those few small changes everything looks good.

>
> Throughout this page, placeholder values in code blocks are formatted as
> `{PLACEHOLDER}` where `PLACEHOLDER` describes the value to fill in.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @felixfontein that this repo is a good place to publish the announcement templates. I think a docs/announcements or maybe just a separate folder at the repo root would work.

I will do a separate PR on this then.

docs/release-process.md Outdated Show resolved Hide resolved
docs/release-process.md Outdated Show resolved Hide resolved
@anweshadas
Copy link
Collaborator

Created the PR #258 for the announcement templates.

@gotmax23 gotmax23 force-pushed the docs-release-process branch from 611adf9 to 510b2a3 Compare July 13, 2023 15:31
@gotmax23 gotmax23 dismissed anweshadas’s stale review July 13, 2023 15:32

The issue brought up about pip have been fixed.

@gotmax23
Copy link
Contributor Author

CI is failing with:

t_systems_mms.icinga_director 2.0.0 is not tagged in https://github.com/T-Systems-MMS/ansible-collection-icinga-director

which is not related to this PR. I'll merge this and then follow the new directions about how to handle these errors :).

Thanks everyone for your feedback!

@gotmax23 gotmax23 merged commit 189cb26 into ansible-community:main Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants