Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrectly inserted endif with d237a77743116a75ab44581f2f2721f23… #193

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Fix incorrectly inserted endif with d237a77743116a75ab44581f2f2721f23… #193

merged 1 commit into from
Mar 18, 2024

Conversation

dosera
Copy link
Contributor

@dosera dosera commented Mar 11, 2024

With #189 incorrect endif and end brackets have been introduced making a nomad client unable to start.
Could only happen when nomad_template_config is used, unfortunately not sufficiently tested (?)

@beechesII beechesII self-requested a review March 18, 2024 07:17
beechesII
beechesII approved these changes Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@beechesII beechesII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contribution. Feel free to add a additional test for this variables.

@beechesII beechesII merged commit 821effa into ansible-community:master Mar 18, 2024
14 checks passed
Rendanic pushed a commit to opitzconsulting/ansible-nomad that referenced this pull request Apr 3, 2024
@dosera @Rendanic
Fix incorrectly inserted endif with d237a77 (ansible-community#193)
15f81a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beechesII beechesII beechesII approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dosera @beechesII