Skip to content

Commit

Permalink
build-release: directly install the wheel for testing (#553)
Browse files Browse the repository at this point in the history
We should test the wheel we build and ship to users instead of having
pip build a new one from the sdist. Also, this makes this task more
efficient. Unpacking the sdist, building the wheel, and then unpacking
and installing that wheel takes a while for a large package such as
ansible.
  • Loading branch information
gotmax23 authored Nov 13, 2023
1 parent ca27ab6 commit 3aca393
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions changelogs/fragments/553-release-wheel-test.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
minor_changes:
- build-release role - directly install the wheel when running tests
(https://github.com/ansible-community/antsibull/pull/553).
4 changes: 2 additions & 2 deletions roles/build-release/tasks/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@
ansible.builtin.set_fact:
_python_version: "python{{ ansible_python.version.major }}.{{ ansible_python.version.minor }}"

- name: Install the release tarball in a virtualenv so we can test it
- name: Install the release wheel in a virtualenv so we can test it
ansible.builtin.pip:
name: "file://{{ _release_archive }}"
name: "file://{{ _release_wheel }}"
state: present
virtualenv: "{{ antsibull_ansible_venv }}"
virtualenv_command: "{{ ansible_python.executable }} -m venv"
Expand Down

0 comments on commit 3aca393

Please sign in to comment.