Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use HTML blobs for option and result value tables #360

Merged
merged 11 commits into from
Dec 15, 2021

Conversation

felixfontein
Copy link
Collaborator

Instead of RST tables. But almost generates the same HTML as the RST tables do, so everything still looks like new and is responsive :)

The main downside of this is that R(...) does not work in those tables (i.e. as before).

The behavior can be turned off (similar to breadcrumbs).

See https://ansible.fontein.de/ for how the result looks.

@samccann
Copy link
Contributor

samccann commented Dec 14, 2021

Initial local testing with html blobs False (default) - (VM with 16G ram and 4 cpus):

  • build time 1 hr (up from 30 minutes without this PR, and 16 minutes with current antsibull release)
  • 805 build warnings (up from 400 ...something without this PR and 190 something with current antsibull release).

I haven't piped the warnings into a file to compare yet because this all brings my laptop to its knees and I can just sit and twiddle my thumbs while it's building now. I'm trying it next with the html blob tables true to see if that speeds things up enough locally.

@felixfontein
Copy link
Collaborator Author

@samccann did you build with or without HTML blobs? If building with them, it should be faster, not slower, and if building without them, there should be no difference to the current build (without this PR).

@samccann
Copy link
Contributor

@felixfontein updated my comment to show it is with the default (html blobs false). Maybe there's gremlins in my VM. I'll try again in the am.

@samccann
Copy link
Contributor

With html blob True - build time 20 minutes and 569 warnings (previously was less than this but I don't recall how much less... 490 maybe?)- same VM I used for prior comment.

@felixfontein felixfontein changed the title Use HTML blobs for option and result value tables Allow to use HTML blobs for option and result value tables Dec 15, 2021
@felixfontein felixfontein merged commit e008164 into ansible-community:main Dec 15, 2021
@felixfontein felixfontein deleted the html-blobs branch December 15, 2021 20:24
@felixfontein
Copy link
Collaborator Author

@samccann thanks a lot for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants