Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python dependency handling #452

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Fix Python dependency handling #452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/452-python-deps-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bugfixes:
- "Fix handling of Python dependency data when building changelogs and collections (https://github.com/ansible-community/antsibull/pull/452)."
1 change: 1 addition & 0 deletions src/antsibull/build_collection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ def build_collection_command():
# Parse the deps file
deps_file = DepsFile(os.path.join(app_ctx.extra['data_dir'], app_ctx.extra['deps_file']))
dummy1_, dummy2_, deps = deps_file.parse()
deps.pop('_python', None)

# Template the galaxy.yml file
dep_string = json.dumps(deps)
Expand Down
1 change: 1 addition & 0 deletions src/antsibull/changelog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,6 +468,7 @@ def get_changelog(
for path in glob.glob(os.path.join(deps_dir, '*.deps'), recursive=False):
deps_file = DepsFile(path)
deps = deps_file.parse()
deps.deps.pop('_python', None)
version = PypiVer(deps.ansible_version)
if version > ansible_version:
print(f"Ignoring {path}, since {deps.ansible_version}"
Expand Down