Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate 'multiple' and 'collection' subcommands #505

Merged
merged 2 commits into from
Apr 7, 2023

Conversation

felixfontein
Copy link
Collaborator

@gotmax23 this is a simple change I would also like to get in the next release. It deprecates two subcommands that have never really been used (to my knowledge), except maybe in the exploratory phase before Ansible 2.10.0, and that aren't tested and might not even work anymore. I'd really like to remove them soon.

@gotmax23
Copy link
Contributor

gotmax23 commented Apr 7, 2023

Yeah, I was going to ask about these and whether we can get rid of. I've never used them, and I doubt they work.

Copy link
Contributor

@gotmax23 gotmax23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd consider printing the deprecation warnings to stderr (i.e. add file=sys.stderr to the print()s, but besides that LGTM.

@felixfontein felixfontein merged commit 74a4bd2 into ansible-community:main Apr 7, 2023
@felixfontein felixfontein deleted the deprecate branch April 7, 2023 21:02
@felixfontein
Copy link
Collaborator Author

@gotmax23 thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants