Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect the EXAMPLES format and use it #225

Merged
merged 2 commits into from
Dec 9, 2023

Conversation

felixfontein
Copy link
Collaborator

Currently the ansible-documentation build fails since ansible/ansible#82361 got merged. This PR fixes the handling of EXAMPLES blocks by using the format specification if provided.

Ref: ansible/ansible#82355 (comment)
Ref: https://github.com/ansible/ansible/blob/6ebefaceb6cd0d4961776a94d63a71fc1fc28bc0/test/lib/ansible_test/_util/controller/sanity/yamllint/yamllinter.py#L173-L187

Copy link
Contributor

@samccann samccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't speak to the code but compared before/after examples and LGTM thanks!

@gotmax23 gotmax23 merged commit 4fa1813 into ansible-community:main Dec 9, 2023
10 checks passed
@gotmax23
Copy link
Collaborator

gotmax23 commented Dec 9, 2023

Thanks!

@felixfontein felixfontein deleted the examples-format branch December 9, 2023 22:21
@felixfontein
Copy link
Collaborator Author

@gotmax23 thanks for reviewing, merging, and releasing!

jooola referenced this pull request in ansible-collections/hetzner.hcloud Dec 11, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[antsibull-docs](https://togithub.com/ansible-community/antsibull-docs)
| `>=2.5.0,<2.6` -> `>=2.6,<2.7` |
[![age](https://developer.mend.io/api/mc/badges/age/pypi/antsibull-docs/2.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/antsibull-docs/2.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/antsibull-docs/2.5.0/2.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/antsibull-docs/2.5.0/2.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>ansible-community/antsibull-docs (antsibull-docs)</summary>

###
[`v2.6.0`](https://togithub.com/ansible-community/antsibull-docs/blob/HEAD/CHANGELOG.rst#v260)

[Compare
Source](https://togithub.com/ansible-community/antsibull-docs/compare/2.5.0...2.6.0)

\======

## Release Summary

Fix parsing of `EXAMPLES` and improve error message

## Minor Changes

- Improve error messages when calls to `ansible-doc` fail
([https://github.com/ansible-community/antsibull-docs/pull/223](https://togithub.com/ansible-community/antsibull-docs/pull/223)).

## Bugfixes

- When `EXAMPLES` has the format specified by `# fmt: <format>`, this
value is used to determine the code block type
([https://github.com/ansible-community/antsibull-docs/pull/225](https://togithub.com/ansible-community/antsibull-docs/pull/225)).

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/ansible-collections/hetzner.hcloud).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants