Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CSS colors flexible #254

Merged
merged 3 commits into from
Mar 10, 2024
Merged

Make CSS colors flexible #254

merged 3 commits into from
Mar 10, 2024

Conversation

felixfontein
Copy link
Collaborator

@felixfontein felixfontein commented Mar 10, 2024 •
edited
Loading

This addresses #253 (review). My idea is to proceed as follows:

  • Use CSS variables for colors in the CSS so they can easily be overridden.
  • Allow to configure color scheme scheme (options default and none).
  • (This should be in another PR, say Added Dark Mode support to option tables #253) Add color scheme default-with-dark-mode (or something like that) that includes dark mode support.

@felixfontein felixfontein mentioned this pull request Mar 10, 2024
Merged
@felixfontein felixfontein marked this pull request as ready for review March 10, 2024 15:01
@felixfontein felixfontein merged commit 23aa5cf into ansible-community:main Mar 10, 2024
12 checks passed
@felixfontein felixfontein deleted the colors branch March 10, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@felixfontein