Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use <code> for default values, sample values, and choice values #42

Merged
merged 4 commits into from
Oct 6, 2022

Conversation

felixfontein
Copy link
Collaborator

Fixes #38.

(The role setup code comes from #4.)

Copy link
Contributor

@briantist briantist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! thanks for working on this @felixfontein

@felixfontein
Copy link
Collaborator Author

I rebased to incorporate the baseline tests; you can now see in the PR how the generated RST files will get updated by this PR.

@samccann
Copy link
Contributor

samccann commented Oct 3, 2022

Can't address the code but the output (based on the issue prototype) LGTM!

@felixfontein felixfontein merged commit 93541f2 into ansible-community:main Oct 6, 2022
@felixfontein felixfontein deleted the code-formatting branch October 6, 2022 04:39
@felixfontein
Copy link
Collaborator Author

Thanks everyone who took a look and commented on this, no matter where :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use code formatting for all values (choice entries, defaults, samples)
3 participants