-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve environment variable handling #73
Conversation
c3f0cb6
to
6aaa181
Compare
6aaa181
to
267fa20
Compare
267fa20
to
435323d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and looks good except the new index of environement variables isn't part of any TOC that I can see? should be be in the list of 'index of xxx' like modules, vars plugins etc?
We should also add a link to this from here? https://docs.ansible.com/ansible/latest/reference_appendices/config.html#ansible-configuration-settings
Yes, it would need to be added there somewhere.
You mean in https://docs.ansible.com/ansible/devel/collections/all_plugins.html ? It would be a bit confusing if "Indexes of all modules and plugins" also contains an index of all environment variables. (On the other hand, that already contains an index of roles, but roles fit better in there than environment variables :) ) I'm not sure what the best place would be.
That requires a code change in ansible/ansible, but would be a good thing IMO. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs and output LGTM
Ok, plan is to move the 'env variable fallback documentation for modules' to a separate PR so the uncontroversial part can be merged first. |
d473e96
to
4a2e5f7
Compare
I removed the module part (it is now a separate PR: #75). |
4a2e5f7
to
b301d0f
Compare
@samccann thanks for reviewing this! |
Improve environment variable handling:
envvar
role).Examples: