Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve environment variable handling #73

Merged
merged 2 commits into from
Dec 6, 2022

Conversation

felixfontein
Copy link
Collaborator

@felixfontein felixfontein commented Nov 26, 2022

Improve environment variable handling:

  • Use the correct Sphinx markup for environment variables (envvar role).
  • Create an environment variable index.

Examples:

Copy link
Contributor

@samccann samccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and looks good except the new index of environement variables isn't part of any TOC that I can see? should be be in the list of 'index of xxx' like modules, vars plugins etc?

We should also add a link to this from here? https://docs.ansible.com/ansible/latest/reference_appendices/config.html#ansible-configuration-settings

@felixfontein
Copy link
Collaborator Author

Tested locally and looks good except the new index of environement variables isn't part of any TOC that I can see?

Yes, it would need to be added there somewhere.

should be be in the list of 'index of xxx' like modules, vars plugins etc?

You mean in https://docs.ansible.com/ansible/devel/collections/all_plugins.html ? It would be a bit confusing if "Indexes of all modules and plugins" also contains an index of all environment variables. (On the other hand, that already contains an index of roles, but roles fit better in there than environment variables :) ) I'm not sure what the best place would be.

We should also add a link to this from here? https://docs.ansible.com/ansible/latest/reference_appendices/config.html#ansible-configuration-settings

That requires a code change in ansible/ansible, but would be a good thing IMO.

Copy link
Contributor

@samccann samccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs and output LGTM

@felixfontein
Copy link
Collaborator Author

Ok, plan is to move the 'env variable fallback documentation for modules' to a separate PR so the uncontroversial part can be merged first.

@felixfontein
Copy link
Collaborator Author

I removed the module part (it is now a separate PR: #75).

@felixfontein felixfontein merged commit 54be8e1 into ansible-community:main Dec 6, 2022
@felixfontein felixfontein deleted the env-vars branch December 6, 2022 17:28
@felixfontein
Copy link
Collaborator Author

@samccann thanks for reviewing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants