Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Allow module to document environment variable fallbacks for options #75

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[WIP] Allow module to document environment variable fallbacks for options #75

wants to merge 1 commit into from

Conversation

felixfontein
Copy link
Collaborator

@felixfontein felixfontein commented Dec 1, 2022 •
edited
Loading

Includes #73.

This is the controversal part of #73, which allows modules to declare environment variable fallbacks for options.

Related to ansible/ansible#79471.

This was referenced Dec 1, 2022
Closed
Merged
@felixfontein felixfontein changed the title [WIP] Allow module to improve environment variable handling [WIP] Allow module to document environment variable fallbacks for options Dec 1, 2022
@felixfontein felixfontein force-pushed the env-vars-modules branch 3 times, most recently from ac79561 to f91f1bb Compare December 23, 2022 06:53
@felixfontein felixfontein mentioned this pull request Jan 4, 2023
Merged
@felixfontein
Copy link
Collaborator Author

felixfontein commented Mar 9, 2023 •
edited
Loading

Rebasing this exposed some problems with semantic markup and the environment variable overview page. I'll fix them next.

@felixfontein felixfontein mentioned this pull request Mar 9, 2023
Merged
@felixfontein felixfontein force-pushed the env-vars-modules branch 2 times, most recently from 76fcb86 to c98e15b Compare March 14, 2023 05:42
@felixfontein felixfontein force-pushed the env-vars-modules branch 2 times, most recently from 66ef0d7 to 65ef588 Compare April 26, 2023 20:24
@felixfontein felixfontein mentioned this pull request May 6, 2023
Merged
@felixfontein felixfontein mentioned this pull request Jun 11, 2023
Closed
@briantist
Copy link
Contributor

The code so far looks good to me. I'm really looking forward to this!

@felixfontein
Copy link
Collaborator Author

Core seems to really be opposed to this, so I'm not sure if this will ever be possible this way...

@felixfontein felixfontein marked this pull request as draft September 27, 2023 11:02
@briantist
Copy link
Contributor

Core seems to really be opposed to this, so I'm not sure if this will ever be possible this way...

I don't see any real discussion in the core ticket :(
I don't really understand why they would be opposed. Modules do have env fallbacks whether they want them to or not, documenting them in a more visible way seems like a win.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felixfontein @briantist