Skip to content
This repository has been archived by the owner on Jan 5, 2023. It is now read-only.

Require community-docker>=3.0.0a2 #155

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

ssbarnea
Copy link
Member

No description provided.

@github-actions github-actions bot added the bug This issue/PR relates to a bug. label Jul 16, 2022
ssbarnea added a commit to ssbarnea/molecule-docker that referenced this pull request Jul 17, 2022
That is a requirement for switching to molecule v3+ but we make this
change separately as we need to update our testing pipelines.

Required-By: ansible-community#155
ssbarnea added a commit to ssbarnea/molecule-docker that referenced this pull request Jul 17, 2022
That is a requirement for switching to molecule v4+ but we make this
change separately as we need to update our testing pipelines.

Required-By: ansible-community#155
ssbarnea added a commit to ssbarnea/molecule-docker that referenced this pull request Jul 17, 2022
That is a requirement for switching to molecule v4+ but we make this
change separately as we need to update our testing pipelines.

Required-By: ansible-community#155
ssbarnea added a commit to ssbarnea/molecule-docker that referenced this pull request Jul 17, 2022
That is a requirement for switching to molecule v4+ but we make this
change separately as we need to update our testing pipelines.

Required-By: ansible-community#155
ssbarnea added a commit to ssbarnea/molecule-docker that referenced this pull request Jul 17, 2022
That is a requirement for switching to molecule v4+ but we make this
change separately as we need to update our testing pipelines.

Required-By: ansible-community#155
ssbarnea added a commit to ssbarnea/molecule-docker that referenced this pull request Jul 17, 2022
That is a requirement for switching to molecule v4+ but we make this
change separately as we need to update our testing pipelines.

Required-By: ansible-community#155
@ssbarnea ssbarnea force-pushed the fix/collection-v3 branch from b9a2d28 to cec20ba Compare July 17, 2022 20:13
@ssbarnea ssbarnea merged commit 31dfd74 into ansible-community:main Jul 18, 2022
@ssbarnea ssbarnea deleted the fix/collection-v3 branch July 18, 2022 10:18
@nre-ableton
Copy link

nre-ableton commented Jul 18, 2022

@ssbarnea Does the a in 3.0.0a2 stand for "alpha"? If so, why is molecule-docker 2.0.0 (stable) now requiring a dependency on an unstable component?

@ssbarnea
Copy link
Member Author

That is because that is the only published version that it would work with. You could expect us to have to do that from time to time. Once we have a full release we can bump it.

@stefanDeveloper
Copy link

stefanDeveloper commented Jul 25, 2022

For me the 3.0.0.a2 in molecule-docker version 2.0.0 did not work and I get the following error:

"stderr_lines": [
        "Traceback (most recent call last):",
        "  File \"/root/.ansible/tmp/ansible-tmp-1658733468.796282-221-168396113268802/AnsiballZ_docker_container.py\", line 107, in <module>",
        "    _ansiballz_main()",
        "  File \"/root/.ansible/tmp/ansible-tmp-1658733468.796282-221-168396113268802/AnsiballZ_docker_container.py\", line 99, in _ansiballz_main",
        "    invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)",
        "  File \"/root/.ansible/tmp/ansible-tmp-1658733468.796282-221-168396113268802/AnsiballZ_docker_container.py\", line 47, in invoke_module",
        "    runpy.run_module(mod_name='ansible_collections.community.docker.plugins.modules.docker_container', init_globals=dict(_module_fqn='ansible_collections.community.docker.plugins.modules.docker_container', _modlib_path=modlib_path),",
        "  File \"/usr/lib/python3.10/runpy.py\", line 209, in run_module",
        "    return _run_module_code(code, init_globals, run_name, mod_spec)",
        "  File \"/usr/lib/python3.10/runpy.py\", line 96, in _run_module_code",
        "    _run_code(code, mod_globals, init_globals,",
        "  File \"/usr/lib/python3.10/runpy.py\", line 86, in _run_code",
        "    exec(code, run_globals)",
        "  File \"/tmp/ansible_community.docker.docker_container_payload_obs29m7_/ansible_community.docker.docker_container_payload.zip/ansible_collections/community/docker/plugins/modules/docker_container.py\", line 1248, in <module>",
        "  File \"/tmp/ansible_community.docker.docker_container_payload_obs29m7_/ansible_community.docker.docker_container_payload.zip/ansible_collections/community/docker/plugins/modules/docker_container.py\", line 1244, in main",
        "  File \"/tmp/ansible_community.docker.docker_container_payload_obs29m7_/ansible_community.docker.docker_container_payload.zip/ansible_collections/community/docker/plugins/module_utils/module_container/module.py\", line 794, in run_module",
        "  File \"/tmp/ansible_community.docker.docker_container_payload_obs29m7_/ansible_community.docker.docker_container_payload.zip/ansible_collections/community/docker/plugins/module_utils/module_container/docker_api.py\", line 172, in setup",
        "  File \"/tmp/ansible_community.docker.docker_container_payload_obs29m7_/ansible_community.docker.docker_container_payload.zip/ansible_collections/community/docker/plugins/module_utils/common_api.py\", line 508, in __init__",
        "  File \"/tmp/ansible_community.docker.docker_container_payload_obs29m7_/ansible_community.docker.docker_container_payload.zip/ansible_collections/community/docker/plugins/module_utils/common_api.py\", line 115, in __init__",
        "  File \"/tmp/ansible_community.docker.docker_container_payload_obs29m7_/ansible_community.docker.docker_container_payload.zip/ansible_collections/community/docker/plugins/module_utils/common_api.py\", line 74, in get_connect_params",
        "TypeError: 'module' object does not support item assignment"
    ],

Reverting molecule-dockerback to version 1.1.0, and my test are fine.
Is there a path when molecule-docker uses a stable component again instead of an alpha version?

@ssbarnea
Copy link
Member Author

@stefanDeveloper what you report looks like a bug in the pre-release so you should report it there with enough info.

@felixfontein
Copy link

That issue should be fixed by ansible-collections/community.docker#432.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants