Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ansible-lint for cookiecutter in CI jobs #122

Closed
zhan9san opened this issue Apr 14, 2023 · 3 comments · Fixed by #123
Closed

Add ansible-lint for cookiecutter in CI jobs #122

zhan9san opened this issue Apr 14, 2023 · 3 comments · Fixed by #123

Comments

@zhan9san
Copy link
Member

Related to #119

Currently, the cookiecutter directory is excluded in ansible-lint configuration.

It may need to run 'molecule init -d xxx' to generate the playbook from cookiecutter.

The lint issue in Azure plugin has been fix in #105
@zhan9san zhan9san changed the title Add ansible-lint for cookiecutter Add ansible-lint for cookiecutter in CI jobs Apr 14, 2023
@apatard
Copy link
Member

apatard commented Apr 14, 2023

sounds a good idea but are you sure that it'll work ? iirc ansible-lint was not really happy with cookiecutter templates

@zhan9san
Copy link
Member Author

That's why I add this line.🤣

It may need to run 'molecule init -d xxx' to generate the playbook from cookiecutter.

@apatard
Copy link
Member

apatard commented Apr 14, 2023

oh, right... Got confused with previous line, I thought you wanted to remove the corresponding exclude_path line in ansible-lint configuration

@wadhah101 wadhah101 mentioned this issue Apr 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enhancement: Generate cookie cutter templates and apply linting on them wadhah101/molecule-plugins
2 participants
@apatard @zhan9san